chrome/browser/extensions/suspicious_extension_bubble_controller.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/suspicious_extension_bubble_controller.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/suspicious_extension_bubble_controller.cc

diff --git a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc

index ea364459e627e75b11358ad1ad4ee1ed2fb7b624..421ef84ce98c22d619124d8f3375b518521dbde3 100644

--- a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc

+++ b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc

@@ -132,8 +132,8 @@ string16 SuspiciousExtensionBubbleController::GetOverflowText(

// this string, whereas we should have used $1. It was discovered too late,

// so we do the substitution by hand in that case.

if (overflow_string.find(ASCIIToUTF16("#")) != string16::npos) {

- ReplaceChars(overflow_string, ASCIIToUTF16("#").c_str(),

- overflow_count, &new_string);

+ base::ReplaceChars(overflow_string, ASCIIToUTF16("#").c_str(),

+ overflow_count, &new_string);

} else {

new_string = l10n_util::GetStringFUTF16(

IDS_EXTENSIONS_SUSPICIOUS_DISABLED_AND_N_MORE,