Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

chrome/test/ppapi/ppapi_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ppapi/ppapi_test.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
@@ skipping 31 matching lines @@
 const char library_name[] = "libppapi_tests.so";
 #endif
 
 }  // namespace
 
 PPAPITestMessageHandler::PPAPITestMessageHandler() {
 }
 
 TestMessageHandler::MessageResponse PPAPITestMessageHandler::HandleMessage(
     const std::string& json) {
- std::string trimmed;
- TrimString(json, "\"", &trimmed);
- if (trimmed == "...") {
-   return CONTINUE;
- } else {
-   message_ = trimmed;
-   return DONE;
- }
+  std::string trimmed;
+  base::TrimString(json, "\"", &trimmed);
+  if (trimmed == "...") {
+    return CONTINUE;
+  } else {

[viettrungluu, 2013/12/03 21:13:44]

If you're going to do a drive-by reindentation, you may as well remove the
unneeded "else".

+    message_ = trimmed;
+    return DONE;
+  }
 }
 
 void PPAPITestMessageHandler::Reset() {
   TestMessageHandler::Reset();
   message_.clear();
 }
 
 PPAPITestBase::InfoBarObserver::InfoBarObserver(PPAPITestBase* test_base)
     : test_base_(test_base),
       expecting_infobar_(false),
@@ skipping 312 matching lines @@
     const std::string& base,
     const std::string& test_case) {
   return base::StringPrintf("%smode=nacl_newlib&testcase=%s", base.c_str(),
                             test_case.c_str());
 }
 
 void PPAPIBrokerInfoBarTest::SetUpOnMainThread() {
   // The default content setting for the PPAPI broker is ASK. We purposefully
   // don't call PPAPITestBase::SetUpOnMainThread() to keep it that way.
 }