chrome/installer/setup/install.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index 5049fdca81bcbfedbcbf4d959a6b40c6fbcd82d2..5c4f305a052d7dacd7329e59fddefd3fb622ff7a 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -289,9 +289,9 @@ installer::InstallShortcutOperation GetAppLauncherShortcutOperation(

namespace installer {

void EscapeXmlAttributeValueInSingleQuotes(string16* att_value) {

- ReplaceChars(*att_value, L"&", L"&", att_value);

- ReplaceChars(*att_value, L"'", L"'", att_value);

- ReplaceChars(*att_value, L"<", L"<", att_value);

+ base::ReplaceChars(*att_value, L"&", L"&", att_value);

+ base::ReplaceChars(*att_value, L"'", L"'", att_value);

+ base::ReplaceChars(*att_value, L"<", L"<", att_value);

}

bool CreateVisualElementsManifest(const base::FilePath& src_path,

« no previous file with comments | « chrome/common/localized_error.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')