chrome/browser/feedback/feedback_data.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/feedback_data.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc ('k') | chrome/browser/guestview/adview/adview_guest.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/feedback_data.cc

diff --git a/chrome/browser/feedback/feedback_data.cc b/chrome/browser/feedback/feedback_data.cc

index 365fbbe788c2c389ab9a58817153c2a7bb2db661..e5dde6a12b084bb961ee8ec0d95b4ae9644e661d 100644

--- a/chrome/browser/feedback/feedback_data.cc

+++ b/chrome/browser/feedback/feedback_data.cc

@@ -56,8 +56,8 @@ std::string LogsToString(const FeedbackData::SystemLogsMap& sys_info) {

if (FeedbackData::BelowCompressionThreshold(value))

continue;

- TrimString(key, "\n ", &key);

- TrimString(value, "\n ", &value);

+ base::TrimString(key, "\n ", &key);

+ base::TrimString(value, "\n ", &value);

if (value.find("\n") != std::string::npos) {

syslogs_string.append(