Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1020963002: Specialize Sk2d for ARM64 (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Specialize Sk2d for ARM64 The implementation is nearly identical to Sk2f, with these changes: - float32x2_t -> float64x2_t - vfoo -> vfooq - one extra Newton's method step in sqrt(). Also, generally fix NEON detection to be defined(SK_ARM_HAS_NEON). SK_ARM_HAS_NEON is not being set on ARM64 bots right now (nor does the compiler seem to set __ARM_NEON__), so this CL fixes everything up. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e57b5cab261a243dcbefa74c91c896c28959bf09 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Build-Ubuntu-GCC-Arm64-Release-Android-Trybot Committed: https://skia.googlesource.com/skia/+/b79ff56de23fef680ae7187040f2d6a9516b553d

Patch Set 1 #

Patch Set 2 : simpler #

Patch Set 3 : rebase #

Patch Set 4 : ios fix? #

Patch Set 5 : Avoid use of vset[q]_lane, instead intializing vectors directly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -76 lines) Patch
M include/core/SkPreConfig.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/Sk2x.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPMFloat.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkUtilsArm.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/Sk2x_neon.h View 1 2 3 4 3 chunks +62 lines, -32 lines 0 comments Download
M src/opts/Sk4x_neon.h View 1 2 3 4 2 chunks +2 lines, -36 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 20:51:57 UTC) #2
reed1
api lgtm
5 years, 9 months ago (2015-03-19 21:13:48 UTC) #3
mtklein
Going to land this now so I can start building more on it.
5 years, 9 months ago (2015-03-20 14:58:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020963002/20001
5 years, 9 months ago (2015-03-20 14:58:42 UTC) #7
commit-bot: I haz the power
Failed to apply patch for src/core/Sk2x.h: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-20 14:58:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020963002/40001
5 years, 9 months ago (2015-03-20 15:03:06 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e57b5cab261a243dcbefa74c91c896c28959bf09
5 years, 9 months ago (2015-03-20 15:32:40 UTC) #13
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1028523003/ by mtklein@google.com. ...
5 years, 9 months ago (2015-03-20 15:46:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020963002/80001
5 years, 9 months ago (2015-03-20 16:10:25 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 16:25:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b79ff56de23fef680ae7187040f2d6a9516b553d

Powered by Google App Engine
This is Rietveld 408576698