Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1028523003: Revert of Specialize Sk2d for ARM64 (Closed)

Created:
5 years, 9 months ago by mtklein
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Specialize Sk2d for ARM64 (patchset #3 id:40001 of https://codereview.chromium.org/1020963002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Mac10.7-Clang-Arm7-Debug-iOS/builds/2441/steps/build%20most/logs/stdio https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Mac10.7-Clang-Arm7-Release-iOS/builds/2424/steps/build%20most/logs/stdio https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Release-Android/builds/8/steps/build%20most/logs/stdio Original issue's description: > Specialize Sk2d for ARM64 > > The implementation is nearly identical to Sk2f, with these changes: > - float32x2_t -> float64x2_t > - vfoo -> vfooq > - one extra Newton's method step in sqrt(). > > Also, generally fix NEON detection to be defined(SK_ARM_HAS_NEON). > SK_ARM_HAS_NEON is not being set on ARM64 bots right now (nor does the compiler > seem to set __ARM_NEON__), so this CL fixes everything up. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e57b5cab261a243dcbefa74c91c896c28959bf09 TBR=msarett@google.com,reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c3ce1d28a53e70f4faa71f9d5bbda605b0664830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -72 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/Sk2x.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPMFloat.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkUtilsArm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/Sk2x_neon.h View 2 chunks +23 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Specialize Sk2d for ARM64
5 years, 9 months ago (2015-03-20 15:46:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028523003/1
5 years, 9 months ago (2015-03-20 15:46:24 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:46:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c3ce1d28a53e70f4faa71f9d5bbda605b0664830

Powered by Google App Engine
This is Rietveld 408576698