Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, yurys, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct time. "Extensions.ExtensionHostMonitoring.NumLoaded" UMA is now correctly recorded. I also cleaned up ExtensionHost and its Start/Stop events a little to make it more obvious, but in a way that my previous attempt at this (r320536) won't cause crashes. R=yoz@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/fd474faa8e4f90615bee3b1da22cd4c1d38c5ef2 Cr-Commit-Position: refs/heads/master@{#320806}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Another rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -151 lines) Patch
M apps/app_lifetime_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_load_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M extensions/browser/deferred_start_render_host_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_host.h View 1 4 chunks +11 lines, -6 lines 0 comments Download
M extensions/browser/extension_host.cc View 1 6 chunks +44 lines, -30 lines 0 comments Download
M extensions/browser/lazy_background_task_queue.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.h View 5 chunks +7 lines, -10 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue.cc View 5 chunks +15 lines, -26 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue_unittest.cc View 12 chunks +120 lines, -44 lines 0 comments Download
M extensions/browser/notification_types.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
not at google - send to devlin
https://codereview.chromium.org/1016473002/diff/1/extensions/browser/extension_host.cc File extensions/browser/extension_host.cc (right): https://codereview.chromium.org/1016473002/diff/1/extensions/browser/extension_host.cc#newcode283 extensions/browser/extension_host.cc:283: if (first_load) { This, and the has_loaded_once_ check in ...
5 years, 9 months ago (2015-03-16 18:48:34 UTC) #2
Yoyo Zhou
LGTM
5 years, 9 months ago (2015-03-16 20:24:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016473002/20001
5 years, 9 months ago (2015-03-16 21:07:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 22:31:11 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:31:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd474faa8e4f90615bee3b1da22cd4c1d38c5ef2
Cr-Commit-Position: refs/heads/master@{#320806}

Powered by Google App Engine
This is Rietveld 408576698