chrome/browser/devtools/devtools_sanity_browsertest.cc - Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another rename Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_sanity_browsertest.cc

diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc

index 09bdc397dcf10e3fc0797fb398a134d5161d2e24..bb8c7424a9814d208604fa3a80a78208013dfe02 100644

--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc

+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc

@@ -350,7 +350,7 @@ class DevToolsExtensionTest : public DevToolsSanityTest,

content::NotificationRegistrar registrar;

registrar.Add(this,

- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,

+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,

content::NotificationService::AllSources());

base::CancelableClosure timeout(

base::Bind(&TimeoutCallback, "Extension host load timed out."));

@@ -378,7 +378,7 @@ class DevToolsExtensionTest : public DevToolsSanityTest,

const content::NotificationDetails& details) override {

switch (type) {

case extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED:

- case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING:

+ case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD:

base::MessageLoopForUI::current()->Quit();

break;

default: