Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another rename Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_dialog.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc
index cc8f31a8094c61e584f67157da3fa817619dff8b..2fbf28a5342d9aa74f98774123d066bda0323440 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc
@@ -40,7 +40,7 @@ ExtensionDialog::ExtensionDialog(extensions::ExtensionViewHost* host,
AddRef(); // Balanced in DeleteDelegate();
registrar_.Add(this,
- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,
content::Source<BrowserContext>(host->browser_context()));
// Listen for the containing view calling window.close();
registrar_.Add(this,
@@ -201,7 +201,7 @@ void ExtensionDialog::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING:
+ case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD:
// Avoid potential overdraw by removing the temporary background after
// the extension finishes loading.
GetExtensionView(host_.get())->set_background(NULL);
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_view_mac.mm ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698