Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/test/base/extension_load_waiter_one_shot.cc

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another rename Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/extension_load_waiter_one_shot.cc
diff --git a/chrome/test/base/extension_load_waiter_one_shot.cc b/chrome/test/base/extension_load_waiter_one_shot.cc
index ccd3661006f5af9a47e6a7552bafef62158f40a4..ae052c691f565714a98c89b210efc0982f5b7a21 100644
--- a/chrome/test/base/extension_load_waiter_one_shot.cc
+++ b/chrome/test/base/extension_load_waiter_one_shot.cc
@@ -25,7 +25,7 @@ void ExtensionLoadWaiterOneShot::WaitForExtension(const char* extension_id,
extension_id_ = extension_id;
load_looper_ = new content::MessageLoopRunner();
registrar_.Add(this,
- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,
content::NotificationService::AllSources());
load_cb.Run();
load_looper_->Run();
@@ -35,15 +35,14 @@ void ExtensionLoadWaiterOneShot::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {
+ case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD: {
extensions::ExtensionHost* host =
content::Details<extensions::ExtensionHost>(details).ptr();
if (host->extension_id() == extension_id_) {
browser_context_ = host->browser_context();
CHECK(browser_context_);
registrar_.Remove(
- this,
- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+ this, extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,
content::NotificationService::AllSources());
load_looper_->Quit();
}
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_view_views.cc ('k') | extensions/browser/deferred_start_render_host_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698