Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/background/background_contents.cc

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another rename Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_load_service.cc ('k') | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents.cc
diff --git a/chrome/browser/background/background_contents.cc b/chrome/browser/background/background_contents.cc
index f0356599d2e4e9d952d9a622b6e3853917f6021d..4f65a1322618fda5076c58c25487cdec26f6a828 100644
--- a/chrome/browser/background/background_contents.cc
+++ b/chrome/browser/background/background_contents.cc
@@ -164,16 +164,20 @@ void BackgroundContents::RenderProcessGone(base::TerminationStatus status) {
void BackgroundContents::DidStartLoading(
content::RenderViewHost* render_view_host) {
+ // BackgroundContents only loads once, so this can only be the first time it
+ // has started loading.
FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,
deferred_start_render_host_observer_list_,
- OnDeferredStartRenderHostDidStartLoading(this));
+ OnDeferredStartRenderHostDidStartFirstLoad(this));
}
void BackgroundContents::DidStopLoading(
content::RenderViewHost* render_view_host) {
+ // BackgroundContents only loads once, so this can only be the first time
+ // it has stopped loading.
FOR_EACH_OBSERVER(extensions::DeferredStartRenderHostObserver,
deferred_start_render_host_observer_list_,
- OnDeferredStartRenderHostDidStopLoading(this));
+ OnDeferredStartRenderHostDidStopFirstLoad(this));
}
void BackgroundContents::Observe(int type,
« no previous file with comments | « apps/app_load_service.cc ('k') | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698