Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 1016473002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another rename Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
index 640b98cbc7d0ef9e776a90e10de9846f6ea1ad63..b0b7b2e4aa003e085a28247f0d55be2a2e898b30 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
@@ -124,7 +124,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
const content::NotificationSource& source,
const content::NotificationDetails& details) override {
switch (type) {
- case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {
+ case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD: {
if (content::Details<extensions::ExtensionViewHost>(
[controller_ extensionViewHost]) == details) {
[controller_ showDevTools];
@@ -309,7 +309,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
// Listen for the extension to finish loading so the dev tools can be
// opened.
registrar_->Add(notificationBridge_.get(),
- extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,
+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD,
content::Source<BrowserContext>(host_->browser_context()));
}
}
@@ -381,7 +381,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
// When we update the size, the window will become visible. Stay hidden until
// the host is loaded.
pendingSize_ = newSize;
- if (!host_ || !host_->did_stop_loading())
+ if (!host_ || !host_->has_loaded_once())
return;
// No need to use CA here, our caller calls us repeatedly to animate the
« no previous file with comments | « chrome/browser/extensions/extension_view_host.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698