[Icons NTP] Working prototype to fetch, store, and display big icons.
End-to-end flow as proof of concept. CL needs to be cleaned and cut up.
Simplistically store all big icons for now, but hiding feature behind flag "IconNTP/Enabled".
BUG=467712
https://codereview.chromium.org/1010783002/diff/1/chrome/browser/favicon/favicon_tab_helper.cc File chrome/browser/favicon/favicon_tab_helper.cc (right): https://codereview.chromium.org/1010783002/diff/1/chrome/browser/favicon/favicon_tab_helper.cc#newcode57 chrome/browser/favicon/favicon_tab_helper.cc:57: big_icon_handler_.reset( maybe put these derefs behind a check for ...
5 years, 9 months ago
(2015-03-16 19:01:00 UTC)
#2
Plans to split this CL: (1) [Icons NTP] Enable Touch Icon parsing, so Chrome gets ...
5 years, 9 months ago
(2015-03-17 15:03:51 UTC)
#4
Plans to split this CL:
(1) [Icons NTP] Enable Touch Icon parsing, so Chrome gets URL (no fetch or
storage).
content/child/runtime_features.cc
content/renderer/render_view_impl.cc
(2) [Icons NTP] Enable Big Icon URL storage and image fetching (Touch Icons
only), behind flag.
chrome/browser/favicon/favicon_handler.cc
chrome/browser/favicon/favicon_handler.h
chrome/browser/favicon/favicon_tab_helper.cc
chrome/browser/favicon/favicon_tab_helper.h
(3) [Icons NTP] Add LargeIconUrlParser.
chrome/chrome_common.gypi
chrome/chrome_tests_unit.gypi
chrome/common/favicon/large_icon_url_parser.cc
chrome/common/favicon/large_icon_url_parser.h
chrome/common/favicon/large_icon_url_parser_unittest.cc
(4) [Icons NTP] Add path_index() to ParsedFallbackIconPath.
chrome/browser/ui/webui/fallback_icon_source.cc
chrome/common/favicon/fallback_icon_url_parser.cc
chrome/common/favicon/fallback_icon_url_parser.h
chrome/common/favicon/fallback_icon_url_parser_unittest.cc
(5) [Icon NTP] FaviconService: Add method to retrieve large icon.
chrome/browser/favicon/favicon_service.cc
chrome/browser/favicon/favicon_service.h
(6) [Icons NTP] Add chrome://large-icon Endpoint, which resizes icon and renders
fallback.
chrome/browser/search/instant_service.cc
chrome/browser/ui/webui/large_icon_source.cc
chrome/browser/ui/webui/large_icon_source.h
chrome/browser/ui/webui/ntp/most_visited_handler.cc
chrome/chrome_browser_ui.gypi
chrome/common/url_constants.cc
chrome/common/url_constants.h
(7) [Icons NTP] Allow chrome-search:// large-icon and fallback-icon endpoints to
use <view_id>/<restricted_id> instead of URL.
chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/searchbox/searchbox.cc
chrome/renderer/searchbox/searchbox.h
(8) [Icon NTP] Make largeIconUrl and fallbackIconUrl available for Local NTP,
behind flag.
chrome/renderer/searchbox/searchbox_extension.cc
(9) [Icon NTP] Make Local NTP render largeIconUrl instead of thumbnail, if
available.
chrome/browser/resources/local_ntp/most_visited_thumbnail.css
chrome/browser/resources/local_ntp/most_visited_thumbnail.js
Workflow dependence (need to commit in this order so Chrome won't break when
flag is off)
Independent: (1), (2), (3), (4), (5), (7), (8), (9)
(6): (3), (5)
Roger McFarlane (Chromium)
Sounds like a plan. Are you going to chop this up, or do you want ...
5 years, 9 months ago
(2015-03-17 15:24:03 UTC)
#5
Sounds like a plan.
Are you going to chop this up, or do you want me to take some pieces and
turn them into new CLs?
On Tue, Mar 17, 2015 at 11:03 AM, <huangs@chromium.org> wrote:
> Plans to split this CL:
>
> (1) [Icons NTP] Enable Touch Icon parsing, so Chrome gets URL (no fetch or
> storage).
> content/child/runtime_features.cc
> content/renderer/render_view_impl.cc
>
> (2) [Icons NTP] Enable Big Icon URL storage and image fetching (Touch Icons
> only), behind flag.
> chrome/browser/favicon/favicon_handler.cc
> chrome/browser/favicon/favicon_handler.h
> chrome/browser/favicon/favicon_tab_helper.cc
> chrome/browser/favicon/favicon_tab_helper.h
>
> (3) [Icons NTP] Add LargeIconUrlParser.
> chrome/chrome_common.gypi
> chrome/chrome_tests_unit.gypi
> chrome/common/favicon/large_icon_url_parser.cc
> chrome/common/favicon/large_icon_url_parser.h
> chrome/common/favicon/large_icon_url_parser_unittest.cc
>
> (4) [Icons NTP] Add path_index() to ParsedFallbackIconPath.
> chrome/browser/ui/webui/fallback_icon_source.cc
> chrome/common/favicon/fallback_icon_url_parser.cc
> chrome/common/favicon/fallback_icon_url_parser.h
> chrome/common/favicon/fallback_icon_url_parser_unittest.cc
>
> (5) [Icon NTP] FaviconService: Add method to retrieve large icon.
> chrome/browser/favicon/favicon_service.cc
> chrome/browser/favicon/favicon_service.h
>
> (6) [Icons NTP] Add chrome://large-icon Endpoint, which resizes icon and
> renders
> fallback.
> chrome/browser/search/instant_service.cc
> chrome/browser/ui/webui/large_icon_source.cc
> chrome/browser/ui/webui/large_icon_source.h
> chrome/browser/ui/webui/ntp/most_visited_handler.cc
> chrome/chrome_browser_ui.gypi
> chrome/common/url_constants.cc
> chrome/common/url_constants.h
>
> (7) [Icons NTP] Allow chrome-search:// large-icon and fallback-icon
> endpoints to
> use <view_id>/<restricted_id> instead of URL.
> chrome/renderer/chrome_content_renderer_client.cc
> chrome/renderer/searchbox/searchbox.cc
> chrome/renderer/searchbox/searchbox.h
>
> (8) [Icon NTP] Make largeIconUrl and fallbackIconUrl available for Local
> NTP,
> behind flag.
> chrome/renderer/searchbox/searchbox_extension.cc
>
> (9) [Icon NTP] Make Local NTP render largeIconUrl instead of thumbnail, if
> available.
> chrome/browser/resources/local_ntp/most_visited_thumbnail.css
> chrome/browser/resources/local_ntp/most_visited_thumbnail.js
>
>
> Workflow dependence (need to commit in this order so Chrome won't break
> when
> flag is off)
> Independent: (1), (2), (3), (4), (5), (7), (8), (9)
> (6): (3), (5)
>
>
> https://chromiumcodereview.appspot.com/1010783002/
>
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
huangs
Specifically, needed to merge with crbug.com/983043003, which moved several files.
5 years, 9 months ago
(2015-03-17 18:29:57 UTC)
#6
Specifically, needed to merge with crbug.com/983043003, which moved several
files.
Issue 1010783002: [Icons NTP] Working prototype to fetch, store, and display big icons.
(Closed)
Created 5 years, 9 months ago by huangs
Modified 5 years, 9 months ago
Reviewers: Roger McFarlane (Chromium)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 9