Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1007563004: [Icons NTP] Enable Touch Icon parsing, so Chrome gets URL (no fetch or storage). (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, beaudoin, Roger McFarlane (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Icons NTP] Enable Touch Icon parsing, so Chrome gets URL (no fetch or storage). This CL makes Apple Touch Icon URLs will be parsed in Blink and passed to FaviconTabHelper::DidUpdateFaviconURL(). This used to be enabled for Android only. On desktop the URLs are parsed, but ignored (so storage into Favicon DB and no image fetching yet). BUG=467712 Committed: https://crrev.com/dde9acebadce3c0018858692db10d0a47338224a Cr-Commit-Position: refs/heads/master@{#320975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M content/child/runtime_features.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-17 19:31:45 UTC) #2
Avi (use Gerrit)
On 2015/03/17 19:31:45, huangs wrote: > PTAL. LGTM but fix your commit description. Not WebKit, ...
5 years, 9 months ago (2015-03-17 20:00:43 UTC) #3
huangs
Thanks. Submitting!
5 years, 9 months ago (2015-03-17 20:02:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007563004/1
5 years, 9 months ago (2015-03-17 20:03:11 UTC) #6
Roger McFarlane (Chromium)
LGTM
5 years, 9 months ago (2015-03-17 20:03:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 21:26:28 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:27:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dde9acebadce3c0018858692db10d0a47338224a
Cr-Commit-Position: refs/heads/master@{#320975}

Powered by Google App Engine
This is Rietveld 408576698