[Icons NTP] Make largeIconUrl and fallbackIconUrl available for Local NTP, behind flag.

[Icons NTP] Make largeIconUrl and fallbackIconUrl available for Local NTP, behind flag.

This renders and injects the chrome-search://large-icon and
chrome-search://fallback-icon URLs for the local NTP, which (in upcoming
CL) uses the presence of these flags to decide whether to render icons
instead of thumbnails. The feature is hidden behind flag "IconNTP/Enabled".

BUG=467712
Committed: https://crrev.com/ac94a3fc8b7c1a8ebacbf69b5dc46161c8272a28
Cr-Commit-Position: refs/heads/master@{#321283}

[huangs, 2015-03-17 20:50:31]

huangs@chromium.org changed reviewers:
+ beaudoin@chromium.org, rogerm@chromium.org, samarth@chromium.org

[huangs, 2015-03-17 20:50:32]

PTAL.

[samarth, 2015-03-17 21:00:29]

Generally lgtm but please wait for the other reviewers.

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
File chrome/renderer/searchbox/searchbox_extension.cc (right):

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox_extension.cc:116:
base::StringPrintf("chrome-search://large-icon/%d/%d/%d",
For many other resources, we use an image set with different sizes to avoid
downsampling.  Would that make sense here as well?

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox_extension.cc:167: if (IsIconNTPEnabled()) {
If we decide to do this, please remember to update
http://www.chromium.org/embeddedsearch.

[huangs, 2015-03-18 22:01:47]

Updated.

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
File chrome/renderer/searchbox/searchbox_extension.cc (right):

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox_extension.cc:116:
base::StringPrintf("chrome-search://large-icon/%d/%d/%d",
So fetching 48 px on non-HD screen?  If there's an easy way then we should do it
in this CL.  Otherwise I'd prefer to view this as an optimization, and worry
about it later.

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox_extension.cc:167: if (IsIconNTPEnabled()) {
Added comment.

[beaudoin, 2015-03-19 02:31:33]

lgtm

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
File chrome/renderer/searchbox/searchbox_extension.cc (right):

https://codereview.chromium.org/1016793003/diff/1/chrome/renderer/searchbox/s...
chrome/renderer/searchbox/searchbox_extension.cc:167: if (IsIconNTPEnabled()) {
On 2015/03/18 22:01:47, huangs wrote:
> Added comment.

Also, I'm tracking the updates needed to http://www.chromium.org/embeddedsearch
added this.

[huangs, 2015-03-19 02:34:00]

The CQ bit was checked by huangs@chromium.org

[huangs, 2015-03-19 02:34:00]

The patchset sent to the CQ was uploaded after l-g-t-m from samarth@chromium.org
Link to the patchset: https://codereview.chromium.org/1016793003/#ps20001
(title: "Added reminder to update website when this is permanent.")

[commit-bot: I haz the power, 2015-03-19 02:34:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1016793003/20001

[commit-bot: I haz the power, 2015-03-19 03:44:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 03:45:14]

Patchset 2 (id:??) landed as
https://crrev.com/ac94a3fc8b7c1a8ebacbf69b5dc46161c8272a28
Cr-Commit-Position: refs/heads/master@{#321283}