[Icons NTP] FaviconService: Add method to retrieve large icon.

[Icons NTP] FaviconService: Add method to retrieve large icon.

The new method GetGenericLargeIconForPageURL() is intended the upcoming
chrome-search://big-icon endpoint, to supply large icon to the NTP. A new
function is needed (rather than using GetLargestRawFaviconForPageURL())
to provide more flexibility, e.g. don't need |icon_types|. Also later we
may update this to return a small favicon for dominant color extraction.

BUG=467712

[huangs, 2015-03-17 20:10:39]

huangs@chromium.org changed reviewers:
+ jam@chromium.org

[huangs, 2015-03-17 20:10:40]

PTAL.

[Roger McFarlane (Chromium), 2015-03-17 20:25:58]

rogerm@chromium.org changed reviewers:
+ rogerm@chromium.org

[Roger McFarlane (Chromium), 2015-03-17 20:25:59]

lgtm

[beaudoin, 2015-03-17 23:42:49]

beaudoin@chromium.org changed reviewers:
+ beaudoin@chromium.org

[beaudoin, 2015-03-17 23:42:50]

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
File components/favicon/core/browser/favicon_service.cc (right):

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
components/favicon/core/browser/favicon_service.cc:209:
Bind(&FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults,
RunFaviconRawBitmapCallbackWithBitmapResults looks like it can perform the
resizing if you don't bind 0 desired_size_in_pixel, but from your other CL you
perform the resizing yourself in the endpoint. I suspect there is a reason for
this, but you should explain it in a comment. (If not, then it looks like
GetRawFavicon() is almost a 1:1 match for this method.)

[huangs, 2015-03-18 20:31:37]

Updated, PTAL.

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
File components/favicon/core/browser/favicon_service.cc (right):

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
components/favicon/core/browser/favicon_service.cc:209:
Bind(&FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults,
Nope, just an oversight.  Using this to do resize now, and removing redundant
code in the other CL.

[huangs, 2015-03-18 20:34:13]

Problem with Patch Set 2: If only low-res favicon is available, it will scale
up! Fixing this.

[huangs, 2015-03-18 22:05:43]

Ping jam@, PTAL. Thanks!

[beaudoin, 2015-03-19 02:36:27]

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
File components/favicon/core/browser/favicon_service.cc (right):

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
components/favicon/core/browser/favicon_service.cc:209:
Bind(&FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults,
On 2015/03/18 20:31:37, huangs wrote:
> Nope, just an oversight.  Using this to do resize now, and removing redundant
> code in the other CL.

Why define this and not use GetRawFavicon directly passing
icon_type = favicon_base::TOUCH_ICON | favicon_base::TOUCH_PRECOMPOSED_ICON ? It
looks like a perfect copy of this function.

[huangs, 2015-03-19 14:46:29]

Update: We can skip this patch to unblock
https://codereview.chromium.org/1016833003/#ps1

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
File components/favicon/core/browser/favicon_service.cc (right):

https://codereview.chromium.org/1018733002/diff/1/components/favicon/core/bro...
components/favicon/core/browser/favicon_service.cc:209:
Bind(&FaviconService::RunFaviconRawBitmapCallbackWithBitmapResults,
That would be GetRawFaviconForPageURL(), but the idea works!  We'll still need
to do work in FaviconService to accommodate large *fav*icons, but for now we can
skip this patch so the next one is unblocked.

[huangs, 2015-03-20 15:26:29]

Closing issue since we don't need it (yet).