Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Issue 1013173003: [Icons NTP] Make Local NTP render largeIconUrl instead of thumbnail, if available. (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Icons NTP] Make Local NTP render largeIconUrl instead of thumbnail, if available. This is a minimalistic way to display large icons on local NTP for testing. The code looks for the "largeIconUrl" data, which only becomes available beyind flag. If not found then use thumbnail as before; otherwise large icons. New NTP styles are not implemented in this CL. BUG=467712 Committed: https://crrev.com/8341df4812ce9c197c321fbf0b3d028bf2d55160 Cr-Commit-Position: refs/heads/master@{#321247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_thumbnail.css View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_thumbnail.js View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-17 20:55:35 UTC) #2
beaudoin
Nice and simple way to implement this! Well done. LGTM
5 years, 9 months ago (2015-03-17 23:29:45 UTC) #3
Mathieu
lgtm
5 years, 9 months ago (2015-03-18 13:37:01 UTC) #4
huangs
Committing. Will handle updating fserb@'s new NTP soon.
5 years, 9 months ago (2015-03-18 22:58:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1013173003/1
5 years, 9 months ago (2015-03-18 22:59:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 00:18:10 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 00:19:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8341df4812ce9c197c321fbf0b3d028bf2d55160
Cr-Commit-Position: refs/heads/master@{#321247}

Powered by Google App Engine
This is Rietveld 408576698