Make helper functions static to avoid accidental collision and potentially aid optimization.

Make helper functions static to avoid accidental collision and potentially aid optimization.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42650

[koda, 2015-01-06 23:50:33]

BTW, these were found by grep'ing.

To address the same issue for classes declared in .cc files, we'd need to
enclose them in an unnamed/anonymous namespace, e.g.:

namespace {
class MyLocalHelperClass {
...
}
}  // namespace

I believe this is fairly standard practice in google3 code. However, it would
clutter the code a bit, or we'd need to reorder our .cc files to separate the
dart:: and anonymous namespace.

What do you think?

[siva, 2015-01-07 00:21:57]

Making helper functions static LGTM.

Adding an anonymous namespace around classes in .cc files
seems like an overkill.

[koda, 2015-01-07 01:02:45]

Committed patchset #2 (id:20001) manually as r42650 (presubmit successful).