runtime/vm/intrinsifier_ia32.cc - Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

===================================================================

--- runtime/vm/intrinsifier_ia32.cc (revision 42643)

+++ runtime/vm/intrinsifier_ia32.cc (working copy)

@@ -1993,7 +1993,7 @@

// TODO(srdjan): Add combinations (one-byte/two-byte/external strings).

-void StringEquality(Assembler* assembler, intptr_t string_cid) {

+static void StringEquality(Assembler* assembler, intptr_t string_cid) {

Label fall_through, is_true, is_false, loop;

__ movl(EAX, Address(ESP, + 2 * kWordSize)); // This.

__ movl(EBX, Address(ESP, + 1 * kWordSize)); // Other.

« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »