Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: runtime/vm/intrinsifier_mips.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1991 matching lines...) Expand 10 before | Expand all | Expand 10 after
2002 TryAllocateOnebyteString(assembler, &ok, &fall_through); 2002 TryAllocateOnebyteString(assembler, &ok, &fall_through);
2003 2003
2004 __ Bind(&ok); 2004 __ Bind(&ok);
2005 __ Ret(); 2005 __ Ret();
2006 2006
2007 __ Bind(&fall_through); 2007 __ Bind(&fall_through);
2008 } 2008 }
2009 2009
2010 2010
2011 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings). 2011 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings).
2012 void StringEquality(Assembler* assembler, intptr_t string_cid) { 2012 static void StringEquality(Assembler* assembler, intptr_t string_cid) {
2013 Label fall_through, is_true, is_false, loop; 2013 Label fall_through, is_true, is_false, loop;
2014 __ lw(T0, Address(SP, 1 * kWordSize)); // This. 2014 __ lw(T0, Address(SP, 1 * kWordSize)); // This.
2015 __ lw(T1, Address(SP, 0 * kWordSize)); // Other. 2015 __ lw(T1, Address(SP, 0 * kWordSize)); // Other.
2016 2016
2017 // Are identical? 2017 // Are identical?
2018 __ beq(T0, T1, &is_true); 2018 __ beq(T0, T1, &is_true);
2019 2019
2020 // Is other OneByteString? 2020 // Is other OneByteString?
2021 __ andi(CMPRES1, T1, Immediate(kSmiTagMask)); 2021 __ andi(CMPRES1, T1, Immediate(kSmiTagMask));
2022 __ beq(CMPRES1, ZR, &fall_through); // Other is Smi. 2022 __ beq(CMPRES1, ZR, &fall_through); // Other is Smi.
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
2143 Isolate* isolate = Isolate::Current(); 2143 Isolate* isolate = Isolate::Current();
2144 __ LoadImmediate(V0, reinterpret_cast<uword>(isolate)); 2144 __ LoadImmediate(V0, reinterpret_cast<uword>(isolate));
2145 // Set return value. 2145 // Set return value.
2146 __ Ret(); 2146 __ Ret();
2147 __ delay_slot()->lw(V0, Address(V0, Isolate::current_tag_offset())); 2147 __ delay_slot()->lw(V0, Address(V0, Isolate::current_tag_offset()));
2148 } 2148 }
2149 2149
2150 } // namespace dart 2150 } // namespace dart
2151 2151
2152 #endif // defined TARGET_ARCH_MIPS 2152 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_ia32.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698