Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: runtime/vm/intrinsifier_arm.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1898 matching lines...) Expand 10 before | Expand all | Expand 10 after
1909 TryAllocateOnebyteString(assembler, &ok, &fall_through); 1909 TryAllocateOnebyteString(assembler, &ok, &fall_through);
1910 1910
1911 __ Bind(&ok); 1911 __ Bind(&ok);
1912 __ Ret(); 1912 __ Ret();
1913 1913
1914 __ Bind(&fall_through); 1914 __ Bind(&fall_through);
1915 } 1915 }
1916 1916
1917 1917
1918 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings). 1918 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings).
1919 void StringEquality(Assembler* assembler, intptr_t string_cid) { 1919 static void StringEquality(Assembler* assembler, intptr_t string_cid) {
1920 Label fall_through, is_true, is_false, loop; 1920 Label fall_through, is_true, is_false, loop;
1921 __ ldr(R0, Address(SP, 1 * kWordSize)); // This. 1921 __ ldr(R0, Address(SP, 1 * kWordSize)); // This.
1922 __ ldr(R1, Address(SP, 0 * kWordSize)); // Other. 1922 __ ldr(R1, Address(SP, 0 * kWordSize)); // Other.
1923 1923
1924 // Are identical? 1924 // Are identical?
1925 __ cmp(R0, Operand(R1)); 1925 __ cmp(R0, Operand(R1));
1926 __ b(&is_true, EQ); 1926 __ b(&is_true, EQ);
1927 1927
1928 // Is other OneByteString? 1928 // Is other OneByteString?
1929 __ tst(R1, Operand(kSmiTagMask)); 1929 __ tst(R1, Operand(kSmiTagMask));
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
2058 Isolate* isolate = Isolate::Current(); 2058 Isolate* isolate = Isolate::Current();
2059 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate)); 2059 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate));
2060 // Set return value to Isolate::current_tag_. 2060 // Set return value to Isolate::current_tag_.
2061 __ ldr(R0, Address(R1, Isolate::current_tag_offset())); 2061 __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
2062 __ Ret(); 2062 __ Ret();
2063 } 2063 }
2064 2064
2065 } // namespace dart 2065 } // namespace dart
2066 2066
2067 #endif // defined TARGET_ARCH_ARM 2067 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698