Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: runtime/vm/intrinsifier_ia32.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // The intrinsic code below is executed before a method has built its frame. 5 // The intrinsic code below is executed before a method has built its frame.
6 // The return address is on the stack and the arguments below it. 6 // The return address is on the stack and the arguments below it.
7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved. 7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
8 // Each intrinsification method returns true if the corresponding 8 // Each intrinsification method returns true if the corresponding
9 // Dart method was intrinsified. 9 // Dart method was intrinsified.
10 10
(...skipping 1975 matching lines...) Expand 10 before | Expand all | Expand 10 after
1986 // EDI: Start address to copy from (untagged). 1986 // EDI: Start address to copy from (untagged).
1987 1987
1988 __ Bind(&ok); 1988 __ Bind(&ok);
1989 __ ret(); 1989 __ ret();
1990 1990
1991 __ Bind(&fall_through); 1991 __ Bind(&fall_through);
1992 } 1992 }
1993 1993
1994 1994
1995 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings). 1995 // TODO(srdjan): Add combinations (one-byte/two-byte/external strings).
1996 void StringEquality(Assembler* assembler, intptr_t string_cid) { 1996 static void StringEquality(Assembler* assembler, intptr_t string_cid) {
1997 Label fall_through, is_true, is_false, loop; 1997 Label fall_through, is_true, is_false, loop;
1998 __ movl(EAX, Address(ESP, + 2 * kWordSize)); // This. 1998 __ movl(EAX, Address(ESP, + 2 * kWordSize)); // This.
1999 __ movl(EBX, Address(ESP, + 1 * kWordSize)); // Other. 1999 __ movl(EBX, Address(ESP, + 1 * kWordSize)); // Other.
2000 2000
2001 // Are identical? 2001 // Are identical?
2002 __ cmpl(EAX, EBX); 2002 __ cmpl(EAX, EBX);
2003 __ j(EQUAL, &is_true, Assembler::kNearJump); 2003 __ j(EQUAL, &is_true, Assembler::kNearJump);
2004 2004
2005 // Is other OneByteString? 2005 // Is other OneByteString?
2006 __ testl(EBX, Immediate(kSmiTagMask)); 2006 __ testl(EBX, Immediate(kSmiTagMask));
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 Isolate::current_tag_offset()); 2135 Isolate::current_tag_offset());
2136 // Set return value to Isolate::current_tag_. 2136 // Set return value to Isolate::current_tag_.
2137 __ movl(EAX, current_tag_addr); 2137 __ movl(EAX, current_tag_addr);
2138 __ ret(); 2138 __ ret();
2139 } 2139 }
2140 2140
2141 #undef __ 2141 #undef __
2142 } // namespace dart 2142 } // namespace dart
2143 2143
2144 #endif // defined TARGET_ARCH_IA32 2144 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698