Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: runtime/vm/object.cc

Issue 838663003: Make helper functions static to avoid accidental collision and potentially aid optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/object_graph.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 6806 matching lines...) Expand 10 before | Expand all | Expand 10 after
6817 const char* function_name = String::Handle(name()).ToCString(); 6817 const char* function_name = String::Handle(name()).ToCString();
6818 intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, 6818 intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name,
6819 static_str, abstract_str, kind_str, const_str) + 1; 6819 static_str, abstract_str, kind_str, const_str) + 1;
6820 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len); 6820 char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
6821 OS::SNPrint(chars, len, kFormat, function_name, 6821 OS::SNPrint(chars, len, kFormat, function_name,
6822 static_str, abstract_str, kind_str, const_str); 6822 static_str, abstract_str, kind_str, const_str);
6823 return chars; 6823 return chars;
6824 } 6824 }
6825 6825
6826 6826
6827 const char* GetFunctionServiceId(const Function& f, const Class& cls) { 6827 static const char* GetFunctionServiceId(const Function& f, const Class& cls) {
6828 Zone* zone = Isolate::Current()->current_zone(); 6828 Zone* zone = Isolate::Current()->current_zone();
6829 // Special kinds of functions use indices in their respective lists. 6829 // Special kinds of functions use indices in their respective lists.
6830 intptr_t id = -1; 6830 intptr_t id = -1;
6831 const char* selector = NULL; 6831 const char* selector = NULL;
6832 if (f.IsNonImplicitClosureFunction()) { 6832 if (f.IsNonImplicitClosureFunction()) {
6833 id = cls.FindClosureIndex(f); 6833 id = cls.FindClosureIndex(f);
6834 selector = "closures"; 6834 selector = "closures";
6835 } else if (f.IsImplicitClosureFunction()) { 6835 } else if (f.IsImplicitClosureFunction()) {
6836 id = cls.FindImplicitClosureFunctionIndex(f); 6836 id = cls.FindImplicitClosureFunctionIndex(f);
6837 selector = "implicit_closures"; 6837 selector = "implicit_closures";
(...skipping 13794 matching lines...) Expand 10 before | Expand all | Expand 10 after
20632 return tag_label.ToCString(); 20632 return tag_label.ToCString();
20633 } 20633 }
20634 20634
20635 20635
20636 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 20636 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
20637 Instance::PrintJSONImpl(stream, ref); 20637 Instance::PrintJSONImpl(stream, ref);
20638 } 20638 }
20639 20639
20640 20640
20641 } // namespace dart 20641 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/object_graph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698