Make more use of generated code in Java analysis server.

Make more use of generated code in Java analysis server.

These request/responses are now up to date with the spec:
- server.status
- analysis.setSubscriptions
- analysis.updateContent
- analysis.flushResults
- analysis.highlights
- analysis.navigation
- analysis.overrides

Type generation was updated so getters of boolean types would be isX instead of getX

HighlightRegion, NavigationRegion and Outline now have the method containsInclusive generated.

Occurrences now has the additional method contains(int) generated.

AddContentOverlay, ChangeContentOverlay and RemoveContentOverlay no longer take a String type as an input to the type.

Removal of many non-generated types defined in spec.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39512

[jwren, 2014-08-24 11:25:33]

Sorry for the big CL- couldn't upload during flight.

There is an inconsistency right now between the output
(consumers/AnalysisServerListener) and input.  The input API has lists of
Objects, while the output has arrays.

Eclipse as a client reads in most things as arrays, which I'd guess was the
motivator for arrays in AnalysisServerListener.  I propose we make the API
consistent by having the listener pass on Lists.  If the client wants arrays,
the client can convert the collections.

[Brian Wilkerson, 2014-08-24 11:53:54]

LGTM

> I propose we make the API consistent by having the listener pass on Lists.

That seems reasonable.

Brian

[Paul Berry, 2014-08-24 12:10:38]

lgtm

https://codereview.chromium.org/474193003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java
(right):

https://codereview.chromium.org/474193003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java:76:
String type = jsonObject.get("type").getAsString();
Since the type is required to be "add", I think the fromJson method should
verify it and throw an exception if it isn't.

You might also consider dropping the "type" field from the class entirely, and
just synthesizing it on the fly in the toJson() method (that's what the Dart
code generator does).  Your call, though.

https://codereview.chromium.org/474193003/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java
(right):

https://codereview.chromium.org/474193003/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java:263:
public Boolean isIsDeprecated() {
That's an unfortunate name.  Not sure "getIsDeprecated" was much better, though
:)

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
(right):

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java:277:
"         'offset': 1,",
Extra space

[jwren, 2014-08-24 12:18:01]

Committed patchset #2 manually as 39512 (presubmit successful).

[scheglov, 2014-08-24 17:18:27]

lgtm

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java
(right):

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java:263:
public Boolean isIsDeprecated() {
Could we not to generate additional "is" if a boolean flag's name already starts
with the "is" prefix?

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java
(right):

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java:295:
assertEquals(new Integer(1), error.getOffset());
Why do we need to wrap ints into Integers?
Aren't we going to make most of the methods (where value is not optional) return
ints soon?

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartReconcilingStrategy.java
(right):

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartReconcilingStrategy.java:343:
AddContentOverlay change = new AddContentOverlay(code);
We need also to use RemoveContentOverlay at some point.

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/OverrideIndicatorManager.java
(right):

https://codereview.chromium.org/474193003/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/OverrideIndicatorManager.java:320:
com.google.dart.server.generated.types.Element superElement =
override.getSuperclassMember().getElement();
"superclassMember" is optional, so probably we may get an NPE here.