Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java

Issue 474193003: Make more use of generated code in Java analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java
index e4c978e66b62f8d134070be5a5a9b5d7ce889f85..10850ab11d06224634c7deb6c2f7aef68dbf37c7 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/HoverProcessor.java
@@ -39,21 +39,8 @@ public class HoverProcessor extends ResultProcessor {
ArrayList<HoverInformation> hovers = new ArrayList<HoverInformation>();
Iterator<JsonElement> iter = resultObject.get("hovers").getAsJsonArray().iterator();
while (iter.hasNext()) {
- JsonElement hoverElem = iter.next();
- if (hoverElem instanceof JsonObject) {
- JsonObject hoverObj = (JsonObject) hoverElem;
- hovers.add(new HoverInformation( //
- hoverObj.get("offset").getAsInt(),
- hoverObj.get("length").getAsInt(),
- safelyGetAsString(hoverObj, "containingLibraryPath"),
- safelyGetAsString(hoverObj, "containingLibraryName"),
- safelyGetAsString(hoverObj, "dartdoc"),
- safelyGetAsString(hoverObj, "elementDescription"),
- safelyGetAsString(hoverObj, "elementKind"),
- safelyGetAsString(hoverObj, "parameter"),
- safelyGetAsString(hoverObj, "propagatedType"),
- safelyGetAsString(hoverObj, "staticType")));
- }
+ JsonObject hoverJsonObject = iter.next().getAsJsonObject();
+ hovers.add(HoverInformation.fromJson(hoverJsonObject));
}
consumer.computedHovers(hovers.toArray(new HoverInformation[hovers.size()]));
}

Powered by Google App Engine
This is Rietveld 408576698