editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java - Issue 474193003: Make more use of generated code in Java analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java

Issue 474193003: Make more use of generated code in Java analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java ('K') | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java ('k') | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AssistsProcessor.java » ('j') | editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java

index 3922a630183375b07783e3aebaddbce2aaf60398..b94d4a316ef6b207acaaadbf36b23d2eb4949c27 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/AnalysisErrorsProcessor.java

@@ -39,11 +39,8 @@ public class AnalysisErrorsProcessor extends ResultProcessor {

ArrayList<AnalysisError> errors = new ArrayList<AnalysisError>();

Iterator<JsonElement> iter = resultObject.get("errors").getAsJsonArray().iterator();

while (iter.hasNext()) {

- JsonElement errorElem = iter.next();

- if (errorElem instanceof JsonObject) {

- JsonObject errorObj = (JsonObject) errorElem;

- errors.add(constructAnalysisError(errorObj));

- }

+ JsonObject errorJsonObject = iter.next().getAsJsonObject();

+ errors.add(AnalysisError.fromJson(errorJsonObject));

}

consumer.computedErrors(errors.toArray(new AnalysisError[errors.size()]));

}