Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java

Issue 474193003: Make more use of generated code in Java analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java
index 4e708ef0e7215e57601e7382b13dcee8b5b3957b..b46d1a529a9abc2cd54b6af6d7c4ce01843b48bf 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartNavigationRegionHyperlink_NEW.java
@@ -15,8 +15,8 @@ package com.google.dart.tools.ui.internal.text.editor;
import com.google.dart.engine.utilities.instrumentation.Instrumentation;
import com.google.dart.engine.utilities.instrumentation.InstrumentationBuilder;
-import com.google.dart.server.NavigationRegion;
import com.google.dart.server.generated.types.Element;
+import com.google.dart.server.generated.types.NavigationRegion;
import org.eclipse.core.resources.IFile;
import org.eclipse.core.runtime.Assert;
@@ -24,6 +24,8 @@ import org.eclipse.jface.text.IRegion;
import org.eclipse.jface.text.Region;
import org.eclipse.jface.text.hyperlink.IHyperlink;
+import java.util.List;
+
/**
* A hyperlink for {@link NavigationRegion}.
*/
@@ -56,9 +58,9 @@ public class DartNavigationRegionHyperlink_NEW implements IHyperlink {
public void open() {
InstrumentationBuilder instrumentation = Instrumentation.builder(this.getClass());
try {
- Element[] targets = region.getTargets();
+ List<Element> targets = region.getTargets();
// Server API has changed, Element not returned in getTargets anymore
- if (targets.length != 0) {
+ if (targets.size() != 0) {
throw new IllegalStateException("Not yet implemented: cannot open NavigationTargets.");
// DartUI.openInEditor(context, targets[0]);
}

Powered by Google App Engine
This is Rietveld 408576698