Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java

Issue 474193003: Make more use of generated code in Java analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java
index 18250b03e8e736644f5de2f891b30bbc99cda1c4..4172d54abf8fdc442b057f3105e5d6ab16e7eebf 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisHighlightsProcessor.java
@@ -13,15 +13,10 @@
*/
package com.google.dart.server.internal.remote.processor;
-import com.google.common.collect.Lists;
import com.google.dart.server.AnalysisServerListener;
-import com.google.dart.server.HighlightRegion;
-import com.google.dart.server.HighlightType;
-import com.google.dart.server.internal.HighlightRegionImpl;
-import com.google.gson.JsonElement;
+import com.google.dart.server.generated.types.HighlightRegion;
import com.google.gson.JsonObject;
-import java.util.Iterator;
import java.util.List;
/**
@@ -42,21 +37,7 @@ public class NotificationAnalysisHighlightsProcessor extends NotificationProcess
public void process(JsonObject response) throws Exception {
JsonObject paramsObject = response.get("params").getAsJsonObject();
String file = paramsObject.get("file").getAsString();
- // prepare region objects iterator
- JsonElement regionsElement = paramsObject.get("regions");
- Iterator<JsonElement> regionObjectIterator = regionsElement.getAsJsonArray().iterator();
- // convert regions
- List<HighlightRegion> regions = Lists.newArrayList();
- while (regionObjectIterator.hasNext()) {
- JsonObject regionObject = regionObjectIterator.next().getAsJsonObject();
- String typeName = regionObject.get("type").getAsString();
- HighlightType type = HighlightType.valueOf(typeName);
- if (type != null) {
- int offset = regionObject.get("offset").getAsInt();
- int length = regionObject.get("length").getAsInt();
- regions.add(new HighlightRegionImpl(offset, length, type));
- }
- }
+ List<HighlightRegion> regions = HighlightRegion.fromJsonArray(paramsObject.get("regions").getAsJsonArray());
// notify listener
getListener().computedHighlights(file, regions.toArray(new HighlightRegion[regions.size()]));
}

Powered by Google App Engine
This is Rietveld 408576698