editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java - Issue 474193003: Make more use of generated code in Java analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java

Issue 474193003: Make more use of generated code in Java analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java ('K') | « editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/JsonProcessor.java ('k') | editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisFlushResultsProcessor.java » ('j') | editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java

index 62867a7c12ce825dc10c404b5712cee59e5c60d7..c9d32df36c5693ebd334e5b2a8a53ed5e548c22f 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/NotificationAnalysisErrorsProcessor.java

@@ -47,7 +47,7 @@ public class NotificationAnalysisErrorsProcessor extends NotificationProcessor {

List<AnalysisError> analysisErrors = Lists.newArrayList();

while (errorElementIterator.hasNext()) {

JsonObject errorObject = errorElementIterator.next().getAsJsonObject();

- AnalysisError analysisError = constructAnalysisError(errorObject);

+ AnalysisError analysisError = AnalysisError.fromJson(errorObject);

if (analysisError != null) {

analysisErrors.add(analysisError);

}