samples/pop_pop_win: now based on StageXL

samples/pop_pop_win: now based on StageXL

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35231

[kevmoo, 2014-04-21 21:26:39]

Absolutely missing copy rights and comments.

But this is no worse than what it was before. :-)

Going to go in w/ Alex as committer

Need to update authors file

[Siggi Cherem (dart-lang), 2014-04-21 22:00:56]

I'm not very familiar with the code, so I mainly brought up a couple nits here
and there.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/platform.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/platform.dart:3: import '../platform_target.dart';
this is already in the package, we suggest to write this as import
"package:pop_pop_win/platform_target.dart";

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/board_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/board_element.dart:6: import '../game.dart';
same here

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_background_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_background_element.dart:5: import
'../game.dart';
ditto

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_background_element.dart:58: BitmapData
boardData = new BitmapData(_boardSize, _boardSize, true, 0x000000);
80 col here and below

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_element.dart:65: var newButtonPressed =
new Bitmap(sta.getBitmapData("button_new_game_clicked"));
this file too

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_root.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_root.dart:24: stage
I'd remove this \n

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/score_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:5: import '../game.dart';
..

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:13: defaultTextFormat = new
TextFormat('Slackey, cursive', 28, Color.Black, leading: 1);
80

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:20: var time =
(game.duration == null) ?
<< (indent -2)

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/square_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:13: 'balloon_pieces_b',
it might be the editor doing this kind of indentation, I think this should just
be all in 1 or 2 lines. Any of these seem better:
static const List<String> _balloonBits = const[
    'balloon_pieces_a', 'balloon_pieces_b', 'balloon_pieces_c',
'balloon_pieces_d'];

static const List<String> _balloonBits = const[
    'balloon_pieces_a',
    'balloon_pieces_b',
    'balloon_pieces_c',
    'balloon_pieces_d',
  ];

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:18: "number_one",
"number_two",
ditto

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:55: useHandCursor =
!_game.gameEnded && [SquareState.hidden,
SquareState.flagged].contains(squareState);
80 ...

[kevmoo, 2014-04-21 22:22:54]

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/platform.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/platform.dart:3: import '../platform_target.dart';
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> this is already in the package, we suggest to write this as import
> "package:pop_pop_win/platform_target.dart";

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/board_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/board_element.dart:6: import '../game.dart';
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> same here

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_background_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_background_element.dart:5: import
'../game.dart';
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_background_element.dart:58: BitmapData
boardData = new BitmapData(_boardSize, _boardSize, true, 0x000000);
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> 80 col here and below

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_element.dart:65: var newButtonPressed =
new Bitmap(sta.getBitmapData("button_new_game_clicked"));
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> this file too

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/game_root.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/game_root.dart:24: stage
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> I'd remove this \n

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/score_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:5: import '../game.dart';
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> ..

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:13: defaultTextFormat = new
TextFormat('Slackey, cursive', 28, Color.Black, leading: 1);
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> 80

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/score_element.dart:20: var time =
(game.duration == null) ?
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> << (indent -2)

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/square_element.dart (right):

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:13: 'balloon_pieces_b',
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> it might be the editor doing this kind of indentation, I think this should
just
> be all in 1 or 2 lines. Any of these seem better:
> static const List<String> _balloonBits = const[
>     'balloon_pieces_a', 'balloon_pieces_b', 'balloon_pieces_c',
> 'balloon_pieces_d'];
> 
> static const List<String> _balloonBits = const[
>     'balloon_pieces_a',
>     'balloon_pieces_b',
>     'balloon_pieces_c',
>     'balloon_pieces_d',
>   ];

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:18: "number_one",
"number_two",
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/242443008/diff/50001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:55: useHandCursor =
!_game.gameEnded && [SquareState.hidden,
SquareState.flagged].contains(squareState);
On 2014/04/21 22:00:56, Siggi Cherem (dart-lang) wrote:
> 80 ...

Done.

[kevmoo, 2014-04-21 22:23:54]

PTAL

[Siggi Cherem (dart-lang), 2014-04-21 22:38:37]

lgtm, thanks Kevin!

https://codereview.chromium.org/242443008/diff/70001/samples/pop_pop_win/lib/...
File samples/pop_pop_win/lib/src/stage/square_element.dart (right):

https://codereview.chromium.org/242443008/diff/70001/samples/pop_pop_win/lib/...
samples/pop_pop_win/lib/src/stage/square_element.dart:12: static const
List<String> _balloonBits = const[
oops, didn't notice it before: const[ => const [ (missing space)

[kevmoo, 2014-04-21 22:59:32]

Committed patchset #6 manually as r35231 (presubmit successful).