Change Bool::Get to return a handle instead of a pointer to a raw object.

Change Bool::Get to return a handle instead of a pointer to a raw object.

Replace occurrences of 'expr ? Bool::True() : Bool::False()' with simply
'Bool::Get(expr)' and analogously for its negation.  The pointer to the raw
object can still be extracted with 'Bool::Get(expr).raw()'.

R=iposva@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26770

[Kevin Millikin (Google), 2013-08-27 10:42:06]

I think this is clearer for the reader and more convenient for the writer.

[srdjan, 2013-08-27 15:32:43]

lgtm

https://codereview.chromium.org/23480005/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23480005/diff/1/runtime/vm/object.h#newcode5106
runtime/vm/object.h:5106: }
Best from both worlds?
add:
static RawBool* GetRaw(bool value)  {
  return Get(value).raw();
}

But I do not think it is absolutely necessary.

[Ivan Posva, 2013-08-27 15:51:25]

LGTM -ip

https://codereview.chromium.org/23480005/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23480005/diff/1/runtime/vm/object.h#newcode5106
runtime/vm/object.h:5106: }
On 2013/08/27 15:32:44, srdjan wrote:
> Best from both worlds?
> add:
> static RawBool* GetRaw(bool value)  {
>   return Get(value).raw();
> }
> 
> But I do not think it is absolutely necessary.

I would think that is overkill.

[Kevin Millikin (Google), 2013-08-28 08:39:30]

Committed patchset #1 manually as r26770 (presubmit successful).