Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: runtime/lib/double.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/identical.cc » ('j') | runtime/vm/object.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/double.cc
diff --git a/runtime/lib/double.cc b/runtime/lib/double.cc
index f69e96328fa884d11b7f58a8729dcc0069b508c2..b37c52609188b56130fa9bed82901bd220093423 100644
--- a/runtime/lib/double.cc
+++ b/runtime/lib/double.cc
@@ -120,14 +120,14 @@ DEFINE_NATIVE_ENTRY(Double_greaterThan, 2) {
OS::Print("Double_greaterThan %s > %s\n",
left.ToCString(), right.ToCString());
}
- return Bool::Get(result);
+ return Bool::Get(result).raw();
}
DEFINE_NATIVE_ENTRY(Double_greaterThanFromInteger, 2) {
const Double& right = Double::CheckedHandle(arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, left, arguments->NativeArgAt(1));
- return Bool::Get(left.AsDoubleValue() > right.value());
+ return Bool::Get(left.AsDoubleValue() > right.value()).raw();
}
@@ -139,14 +139,14 @@ DEFINE_NATIVE_ENTRY(Double_equal, 2) {
OS::Print("Double_equal %s == %s\n",
left.ToCString(), right.ToCString());
}
- return Bool::Get(result);
+ return Bool::Get(result).raw();
}
DEFINE_NATIVE_ENTRY(Double_equalToInteger, 2) {
const Double& left = Double::CheckedHandle(arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, right, arguments->NativeArgAt(1));
- return Bool::Get(left.value() == right.AsDoubleValue());
+ return Bool::Get(left.value() == right.AsDoubleValue()).raw();
}
@@ -265,20 +265,20 @@ DEFINE_NATIVE_ENTRY(Double_toStringAsPrecision, 2) {
DEFINE_NATIVE_ENTRY(Double_getIsInfinite, 1) {
const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
- return Bool::Get(isinf(arg.value()));
+ return Bool::Get(isinf(arg.value())).raw();
}
DEFINE_NATIVE_ENTRY(Double_getIsNaN, 1) {
const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
- return Bool::Get(isnan(arg.value()));
+ return Bool::Get(isnan(arg.value())).raw();
}
DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
// Include negative zero, infinity.
- return Bool::Get(signbit(arg.value()) && !isnan(arg.value()));
+ return Bool::Get(signbit(arg.value()) && !isnan(arg.value())).raw();
}
// Add here only functions using/referring to old-style casts.
« no previous file with comments | « no previous file | runtime/lib/identical.cc » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698