Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 __ LoadObject(R0, Bool::True()); 612 __ LoadObject(R0, Bool::True());
613 __ cmp(R1, ShifterOperand(R0)); 613 __ cmp(R1, ShifterOperand(R0));
614 __ b(&done, NE); 614 __ b(&done, NE);
615 __ LoadObject(R0, Bool::False()); 615 __ LoadObject(R0, Bool::False());
616 } else { 616 } else {
617 __ Pop(R0); 617 __ Pop(R0);
618 } 618 }
619 __ b(&done); 619 __ b(&done);
620 } 620 }
621 __ Bind(&is_not_instance); 621 __ Bind(&is_not_instance);
622 __ LoadObject(R0, negate_result ? Bool::True() : Bool::False()); 622 __ LoadObject(R0, Bool::Get(negate_result));
623 __ b(&done); 623 __ b(&done);
624 624
625 __ Bind(&is_instance); 625 __ Bind(&is_instance);
626 __ LoadObject(R0, negate_result ? Bool::False() : Bool::True()); 626 __ LoadObject(R0, Bool::Get(!negate_result));
627 __ Bind(&done); 627 __ Bind(&done);
628 // Remove instantiator (R2) and its type arguments (R1). 628 // Remove instantiator (R2) and its type arguments (R1).
629 __ Drop(2); 629 __ Drop(2);
630 } 630 }
631 631
632 632
633 // Optimize assignable type check by adding inlined tests for: 633 // Optimize assignable type check by adding inlined tests for:
634 // - NULL -> return NULL. 634 // - NULL -> return NULL.
635 // - Smi -> compile time subtype check (only if dst class is not parameterized). 635 // - Smi -> compile time subtype check (only if dst class is not parameterized).
636 // - Class equality (only if class is not parameterized). 636 // - Class equality (only if class is not parameterized).
(...skipping 1268 matching lines...) Expand 10 before | Expand all | Expand 10 after
1905 DRegister dreg = EvenDRegisterOf(reg); 1905 DRegister dreg = EvenDRegisterOf(reg);
1906 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1906 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1907 } 1907 }
1908 1908
1909 1909
1910 #undef __ 1910 #undef __
1911 1911
1912 } // namespace dart 1912 } // namespace dart
1913 1913
1914 #endif // defined TARGET_ARCH_ARM 1914 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698