Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index e451bf09495fc3f37cb3f3284b56137175217e8b..0a5abe5a6c6cd5d321c458b3a8269ea0da40809c 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -403,8 +403,8 @@ static void EmitEqualityAsInstanceCall(FlowGraphCompiler* compiler,
// No need to update IC data.
__ PopList((1 << R0) | (1 << R1));
__ cmp(R0, ShifterOperand(R1));
- __ LoadObject(R0, (kind == Token::kEQ) ? Bool::False() : Bool::True(), NE);
- __ LoadObject(R0, (kind == Token::kEQ) ? Bool::True() : Bool::False(), EQ);
+ __ LoadObject(R0, Bool::Get(kind != Token::kEQ), NE);
+ __ LoadObject(R0, Bool::Get(kind == Token::kEQ), EQ);
if (kind == Token::kNE) {
// Skip not-equal result conversion.
__ b(&equality_done);
@@ -588,10 +588,8 @@ static void EmitCheckedStrictEqual(FlowGraphCompiler* compiler,
__ cmp(left, ShifterOperand(right));
if (branch == NULL) {
Register result = locs.out().reg();
- __ LoadObject(result,
- (kind == Token::kEQ) ? Bool::True() : Bool::False(), EQ);
- __ LoadObject(result,
- (kind == Token::kEQ) ? Bool::False() : Bool::True(), NE);
+ __ LoadObject(result, Bool::Get(kind == Token::kEQ), EQ);
+ __ LoadObject(result, Bool::Get(kind != Token::kEQ), NE);
} else {
Condition cond = TokenKindToSmiCondition(kind);
branch->EmitBranchOnCondition(compiler, cond);
@@ -4535,7 +4533,7 @@ void StrictCompareInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
const bool result = (kind() == Token::kEQ_STRICT) ?
left.constant().raw() == right.constant().raw() :
left.constant().raw() != right.constant().raw();
- __ LoadObject(locs()->out().reg(), result ? Bool::True() : Bool::False());
+ __ LoadObject(locs()->out().reg(), Bool::Get(result));
return;
}
if (left.IsConstant()) {

Powered by Google App Engine
This is Rietveld 408576698