Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: runtime/lib/simd128.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/simd128.cc
diff --git a/runtime/lib/simd128.cc b/runtime/lib/simd128.cc
index 1d4d55179260b12d0ffa9620f5e87017ef2bc960..d128e83a343389d239202efb3fb79f60cbb65cf5 100644
--- a/runtime/lib/simd128.cc
+++ b/runtime/lib/simd128.cc
@@ -591,28 +591,28 @@ DEFINE_NATIVE_ENTRY(Uint32x4_setW, 2) {
DEFINE_NATIVE_ENTRY(Uint32x4_getFlagX, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
uint32_t value = self.x();
- return value != 0 ? Bool::True().raw() : Bool::False().raw();
+ return Bool::Get(value != 0).raw();
}
DEFINE_NATIVE_ENTRY(Uint32x4_getFlagY, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
uint32_t value = self.y();
- return value != 0 ? Bool::True().raw() : Bool::False().raw();
+ return Bool::Get(value != 0).raw();
}
DEFINE_NATIVE_ENTRY(Uint32x4_getFlagZ, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
uint32_t value = self.z();
- return value != 0 ? Bool::True().raw() : Bool::False().raw();
+ return Bool::Get(value != 0).raw();
}
DEFINE_NATIVE_ENTRY(Uint32x4_getFlagW, 1) {
GET_NON_NULL_NATIVE_ARGUMENT(Uint32x4, self, arguments->NativeArgAt(0));
uint32_t value = self.w();
- return value != 0 ? Bool::True().raw() : Bool::False().raw();
+ return Bool::Get(value != 0).raw();
}
« no previous file with comments | « runtime/lib/regexp.cc ('k') | runtime/vm/code_generator.cc » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698