Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_mips.cc
diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc
index dafa9b83cfc1c27748457030af08ebb067aa8c45..77d542eb8422013358c1ee586259631667fca46d 100644
--- a/runtime/vm/intermediate_language_mips.cc
+++ b/runtime/vm/intermediate_language_mips.cc
@@ -400,10 +400,10 @@ static void EmitEqualityAsInstanceCall(FlowGraphCompiler* compiler,
__ lw(A0, Address(SP, 0 * kWordSize));
__ addiu(SP, SP, Immediate(2 * kWordSize));
__ beq(A1, A0, &is_true);
- __ LoadObject(V0, (kind == Token::kEQ) ? Bool::False() : Bool::True());
+ __ LoadObject(V0, Bool::Get(kind != Token::kEQ));
__ b(&equality_done);
__ Bind(&is_true);
- __ LoadObject(V0, (kind == Token::kEQ) ? Bool::True() : Bool::False());
+ __ LoadObject(V0, Bool::Get(kind == Token::kEQ));
if (kind == Token::kNE) {
// Skip not-equal result conversion.
__ b(&equality_done);
@@ -620,12 +620,10 @@ static void EmitCheckedStrictEqual(FlowGraphCompiler* compiler,
Register result = locs.out().reg();
__ beq(CMPRES, ZR, &is_equal);
// Not equal.
- __ LoadObject(result,
- (kind == Token::kEQ) ? Bool::False() : Bool::True());
+ __ LoadObject(result, Bool::Get(kind != Token::kEQ));
__ b(&done);
__ Bind(&is_equal);
- __ LoadObject(result,
- (kind == Token::kEQ) ? Bool::True() : Bool::False());
+ __ LoadObject(result, Bool::Get(kind == Token::kEQ));
__ Bind(&done);
} else {
@@ -3954,7 +3952,7 @@ void StrictCompareInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
const bool result = (kind() == Token::kEQ_STRICT) ?
left.constant().raw() == right.constant().raw() :
left.constant().raw() != right.constant().raw();
- __ LoadObject(locs()->out().reg(), result ? Bool::True() : Bool::False());
+ __ LoadObject(locs()->out().reg(), Bool::Get(result));
return;
}
if (left.IsConstant()) {

Powered by Google App Engine
This is Rietveld 408576698