Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960503002: Fix all strong-mode errors and warnings. (Closed)

Created:
4 years, 7 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : .analysis_options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -168 lines) Patch
A .analysis_options View 1 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/backend/live_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/executable.dart View 2 chunks +2 lines, -1 line 0 comments Download
M lib/src/frontend/throws_matcher.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/src/frontend/timeout.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/browser/content_shell.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M lib/src/runner/browser/dartium.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M lib/src/runner/browser/phantom_js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/browser/platform.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M lib/src/runner/browser/polymer.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M lib/src/runner/configuration.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 3 chunks +10 lines, -8 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M lib/src/runner/load_suite.dart View 3 chunks +12 lines, -1 line 0 comments Download
M lib/src/runner/loader.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/parse_metadata.dart View 4 chunks +22 lines, -17 lines 0 comments Download
M lib/src/runner/plugin/platform_helpers.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M lib/src/runner/reporter/json.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/util/forkable_stream.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M lib/src/util/io.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/util/stream_queue.dart View 12 chunks +19 lines, -19 lines 0 comments Download
M lib/src/utils.dart View 5 chunks +22 lines, -56 lines 0 comments Download
M lib/test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 7 months ago (2016-05-05 23:50:21 UTC) #1
kevmoo
lgtm
4 years, 7 months ago (2016-05-06 00:00:16 UTC) #2
nweiz
4 years, 7 months ago (2016-05-09 19:01:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8d3fd332d35b4a6df2be69472d2f5edf81fee82c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698