Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: lib/src/runner/browser/phantom_js.dart

Issue 1960503002: Fix all strong-mode errors and warnings. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: .analysis_options Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/dartium.dart ('k') | lib/src/runner/browser/platform.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/phantom_js.dart
diff --git a/lib/src/runner/browser/phantom_js.dart b/lib/src/runner/browser/phantom_js.dart
index 5ca5cd136c2ca2e21fd9539b16d0764ab45a4535..a3097e049bab66912e90a7ecf5a7e1c2ce2f62f7 100644
--- a/lib/src/runner/browser/phantom_js.dart
+++ b/lib/src/runner/browser/phantom_js.dart
@@ -40,7 +40,7 @@ class PhantomJS extends Browser {
final Future<Uri> remoteDebuggerUrl;
factory PhantomJS(url, {String executable, bool debug: false}) {
- var remoteDebuggerCompleter = new Completer.sync();
+ var remoteDebuggerCompleter = new Completer<Uri>.sync();
return new PhantomJS._(() async {
if (executable == null) {
executable = Platform.isWindows ? "phantomjs.exe" : "phantomjs";
@@ -52,7 +52,7 @@ class PhantomJS extends Browser {
var port = debug ? await getUnsafeUnusedPort() : null;
- var args = [];
+ var args = <String>[];
if (debug) {
args.addAll([
"--remote-debugger-port=$port",
« no previous file with comments | « lib/src/runner/browser/dartium.dart ('k') | lib/src/runner/browser/platform.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698