Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: lib/src/runner/browser/platform.dart

Issue 1960503002: Fix all strong-mode errors and warnings. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: .analysis_options Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/phantom_js.dart ('k') | lib/src/runner/browser/polymer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/platform.dart
diff --git a/lib/src/runner/browser/platform.dart b/lib/src/runner/browser/platform.dart
index f1a4b2999f795a463911c995d1c47df7f295cf73..057668543a2d3883151af9727408f8c2d24fd713 100644
--- a/lib/src/runner/browser/platform.dart
+++ b/lib/src/runner/browser/platform.dart
@@ -15,6 +15,7 @@ import 'package:shelf/shelf_io.dart' as shelf_io;
import 'package:shelf_static/shelf_static.dart';
import 'package:shelf_web_socket/shelf_web_socket.dart';
import 'package:stream_channel/stream_channel.dart';
+import 'package:web_socket_channel/web_socket_channel.dart';
import '../../backend/metadata.dart';
import '../../backend/test_platform.dart';
@@ -282,7 +283,7 @@ class BrowserPlatform extends PlatformPlugin {
? dartUrl.replace(path: dartUrl.path + '.js.map')
: dartUrl;
- var response;
+ HttpClientResponse response;
try {
var request = await _http.getUrl(url);
response = await request.close();
@@ -370,7 +371,7 @@ class BrowserPlatform extends PlatformPlugin {
var manager = _browserManagers[platform];
if (manager != null) return Result.release(manager);
- var completer = new Completer.sync();
+ var completer = new Completer<WebSocketChannel>.sync();
var path = _webSocketHandler.create(webSocketHandler(completer.complete));
var webSocketUrl = url.replace(scheme: 'ws').resolve(path);
var hostUrl = (_config.pubServeUrl == null ? url : _config.pubServeUrl)
« no previous file with comments | « lib/src/runner/browser/phantom_js.dart ('k') | lib/src/runner/browser/polymer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698