Fix all strong-mode errors and warnings.

lib/src/runner/parse_metadata.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:path/path.dart' as p;
 import 'package:source_span/source_span.dart';
@@ skipping 23 matching lines @@
 
   _Parser(String path)
       : _path = path {
     var contents = new File(path).readAsStringSync();
     var directives = parseDirectives(contents, name: path).directives;
     _annotations = directives.isEmpty ? [] : directives.first.metadata;
 
     // We explicitly *don't* just look for "package:test" imports here,
     // because it could be re-exported from another library.
     _prefixes = directives.map((directive) {
-      if (directive is! ImportDirective) return null;
-      if (directive.prefix == null) return null;
-      return directive.prefix.name;
+      if (directive is ImportDirective) {
+        if (directive.prefix == null) return null;
+        return directive.prefix.name;
+      } else {
+        return null;
+      }
     }).where((prefix) => prefix != null).toSet();
   }
 
   /// Parses the metadata.
   Metadata parse() {
-    var timeout;
-    var testOn;
+    Timeout timeout;
+    PlatformSelector testOn;
     var skip;
-    var onPlatform;
-    var tags;
+    Map<PlatformSelector, Metadata> onPlatform;
+    Set<String> tags;
 
     for (var annotation in _annotations) {
       var pair = _resolveConstructor(
           annotation.name, annotation.constructorName);
       var name = pair.first;
       var constructorName = pair.last;
 
       if (name == 'TestOn') {
         _assertSingle(testOn, 'TestOn', annotation);
         testOn = _parseTestOn(annotation, constructorName);
@@ skipping 181 matching lines @@
 
       return new Metadata.parse(timeout: timeout, skip: skip);
     });
   }
 
   /// Parses a `const Duration` expression.
   Duration _parseDuration(Expression expression) {
     _parseConstructor(expression, 'Duration');
 
     var constructor = expression as InstanceCreationExpression;
-    var values = _assertArguments(
+    var valueExpressions = _assertArguments(
         constructor.argumentList, 'Duration', constructor, named: [
       'days', 'hours', 'minutes', 'seconds', 'milliseconds', 'microseconds'
     ]);
 
-    for (var key in values.keys.toList()) {
-      if (values.containsKey(key)) values[key] = _parseInt(values[key]);
-    }
+    var values = mapMap(valueExpressions,
+        value: (_, value) => _parseInt(value));
 
     return new Duration(
         days: values["days"] == null ? 0 : values["days"],
         hours: values["hours"] == null ? 0 : values["hours"],
         minutes: values["minutes"] == null ? 0 : values["minutes"],
         seconds: values["seconds"] == null ? 0 : values["seconds"],
         milliseconds: values["milliseconds"] == null ? 0 : values["milliseconds"],
         microseconds:
             values["microseconds"] == null ? 0 : values["microseconds"]);
   }
@@ skipping 110 matching lines @@
     if (positional == null) positional = 0;
     if (optional == null) optional = 0;
     if (named == null) named = new Set();
 
     if (arguments == null) {
       throw new SourceSpanFormatException(
           '$name takes arguments.', _spanFor(node));
     }
 
     var actualNamed = arguments.arguments
-        .where((arg) => arg is NamedExpression).toList();
+        .where((arg) => arg is NamedExpression)
+        .map((arg) => arg as NamedExpression)
+        .toList();
     if (!actualNamed.isEmpty && named.isEmpty) {
       throw new SourceSpanFormatException(
           "$name doesn't take named arguments.", _spanFor(actualNamed.first));
     }
 
-    var namedValues = {};
+    var namedValues = <String, Expression>{};
     for (var argument in actualNamed) {
       var argumentName = argument.name.label.name;
       if (!named.contains(argumentName)) {
         throw new SourceSpanFormatException(
             '$name doesn\'t take an argument named "$argumentName".',
             _spanFor(argument));
       } else if (namedValues.containsKey(argumentName)) {
         throw new SourceSpanFormatException(
             'An argument named "$argumentName" was already passed.',
             _spanFor(argument));
@@ skipping 38 matching lines @@
   void _assertNoArguments(Annotation annotation, String name) {
     if (annotation.arguments == null) return;
     throw new SourceSpanFormatException(
         "$name doesn't take arguments.", _spanFor(annotation));
   }
 
   /// Parses a Map literal.
   ///
   /// By default, returns [Expression] keys and values. These can be overridden
   /// with the [key] and [value] parameters.
-  Map _parseMap(Expression expression, {key(Expression expression),
-      value(Expression expression)}) {
-    if (key == null) key = (expression) => expression;
-    if (value == null) value = (expression) => expression;
+  Map/*<K, V>*/ _parseMap/*<K, V>*/(Expression expression,
+      {/*=K*/ key(Expression expression),
+      /*=V*/ value(Expression expression)}) {
+    if (key == null) key = (expression) => expression as dynamic/*=K*/;
+    if (value == null) value = (expression) => expression as dynamic/*=V*/;
 
     if (expression is! MapLiteral) {
       throw new SourceSpanFormatException(
           "Expected a Map.", _spanFor(expression));
     }
 
     var map = expression as MapLiteral;
     if (map.constKeyword == null) {
       throw new SourceSpanFormatException(
           "Map literals must be const.", _spanFor(map));
@@ skipping 58 matching lines @@
       return fn();
     } on SourceSpanFormatException catch (error) {
       var file = new SourceFile(new File(_path).readAsStringSync(),
           url: p.toUri(_path));
       var span = contextualizeSpan(error.span, literal, file);
       if (span == null) rethrow;
       throw new SourceSpanFormatException(error.message, span);
     }
   }
 }