Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: lib/src/runner/configuration.dart

Issue 1960503002: Fix all strong-mode errors and warnings. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: .analysis_options Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/polymer.dart ('k') | lib/src/runner/configuration/args.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration.dart
diff --git a/lib/src/runner/configuration.dart b/lib/src/runner/configuration.dart
index 5f9689a8ebdb37d609bfbc431d670ef4ef5ede3c..5e733ff618a95a8129266a0ed12c96d449657fa9 100644
--- a/lib/src/runner/configuration.dart
+++ b/lib/src/runner/configuration.dart
@@ -280,7 +280,7 @@ class Configuration {
Iterable<String> chosenPresets,
BooleanSelector includeTags,
BooleanSelector excludeTags,
- Iterable addTags,
+ Iterable<String> addTags,
Map<BooleanSelector, Configuration> tags,
Map<PlatformSelector, Configuration> onPlatform,
Map<String, Configuration> presets}) {
@@ -374,7 +374,7 @@ class Configuration {
Iterable<String> chosenPresets,
BooleanSelector includeTags,
BooleanSelector excludeTags,
- Iterable addTags,
+ Iterable<String> addTags,
Map<BooleanSelector, Configuration> tags,
Map<PlatformSelector, Configuration> onPlatform,
Map<String, Configuration> presets})
@@ -426,16 +426,16 @@ class Configuration {
///
/// If [input] is `null` or empty, this returns `null`. Otherwise, it returns
/// `input.toList()`.
- static List _list(Iterable input) {
+ static List/*<T>*/ _list/*<T>*/(Iterable/*<T>*/ input) {
if (input == null) return null;
- input = new List.unmodifiable(input);
- if (input.isEmpty) return null;
- return input;
+ var list = new List/*<T>*/.unmodifiable(input);
+ if (list.isEmpty) return null;
+ return list;
}
- /// Returns an modifiable copy of [input] or an empty unmodifiable map.
- static Map _map(Map input) {
- if (input == null) return const {};
+ /// Returns an unmodifiable copy of [input] or an empty unmodifiable map.
+ static Map/*<K, V>*/ _map/*<K, V>*/(Map/*<K, V>*/ input) {
+ if (input == null || input.isEmpty) return const {};
return new Map.unmodifiable(input);
}
@@ -511,7 +511,7 @@ class Configuration {
Iterable<String> chosenPresets,
BooleanSelector includeTags,
BooleanSelector excludeTags,
- Iterable addTags,
+ Iterable<String> addTags,
Map<BooleanSelector, Configuration> tags,
Map<PlatformSelector, Configuration> onPlatform,
Map<String, Configuration> presets}) {
« no previous file with comments | « lib/src/runner/browser/polymer.dart ('k') | lib/src/runner/configuration/args.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698