Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: lib/src/runner/browser/content_shell.dart

Issue 1960503002: Fix all strong-mode errors and warnings. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: .analysis_options Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/content_shell.dart
diff --git a/lib/src/runner/browser/content_shell.dart b/lib/src/runner/browser/content_shell.dart
index a4d7bb61b6799e1e6d68517173223a846cbe73b2..35908dcf8532779d596f5741a3d4d6920227f8fe 100644
--- a/lib/src/runner/browser/content_shell.dart
+++ b/lib/src/runner/browser/content_shell.dart
@@ -28,12 +28,12 @@ class ContentShell extends Browser {
final Future<Uri> remoteDebuggerUrl;
factory ContentShell(url, {String executable, bool debug: false}) {
- var observatoryCompleter = new Completer.sync();
- var remoteDebuggerCompleter = new Completer.sync();
+ var observatoryCompleter = new Completer<Uri>.sync();
+ var remoteDebuggerCompleter = new Completer<Uri>.sync();
return new ContentShell._(() {
if (executable == null) executable = _defaultExecutable();
- tryPort([port]) async {
+ var tryPort = ([int port]) async {
var args = ["--dump-render-tree", url.toString()];
if (port != null) args.add("--remote-debugging-port=$port");
@@ -88,10 +88,10 @@ class ContentShell extends Browser {
stderr.cancel();
return process;
- }
+ };
if (!debug) return tryPort();
- return getUnusedPort(tryPort);
+ return getUnusedPort/*<Future<Process>>*/(tryPort);
}, observatoryCompleter.future, remoteDebuggerCompleter.future);
}
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698