Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177963002: Use List instead of Link in the type system. (Closed)

Created:
6 years, 10 months ago by karlklose
Modified:
6 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Use List instead of Link in the type system. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37875

Patch Set 1 #

Patch Set 2 : #

Total comments: 27

Patch Set 3 : Address comments. #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Fix failures in unit tests. #

Patch Set 7 : Rebase and some algorithmic bugs fixed. #

Total comments: 2

Patch Set 8 : Rebase. #

Patch Set 9 : #

Patch Set 10 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -597 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 2 3 4 5 6 7 1 chunk +4 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 2 3 4 5 6 7 43 chunks +214 lines, -242 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 3 4 5 6 7 8 9 7 chunks +21 lines, -22 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart View 1 2 3 4 5 6 7 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 2 3 4 5 6 7 1 chunk +7 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 2 3 4 5 6 7 8 12 chunks +37 lines, -42 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_type_mirrors.dart View 1 2 3 4 5 6 7 2 chunks +5 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 2 3 4 5 6 7 2 chunks +4 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/class_members.dart View 1 2 3 4 5 6 7 8 4 chunks +13 lines, -23 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 5 6 7 8 10 chunks +36 lines, -39 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/scope.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/signatures.dart View 1 2 3 4 5 6 7 2 chunks +11 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 3 4 5 6 7 9 chunks +41 lines, -36 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 2 3 4 5 6 7 6 chunks +22 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/link.dart View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -19 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/util.dart View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/least_upper_bound_test.dart View 1 2 3 4 5 6 7 2 chunks +6 lines, -7 lines 0 comments Download
A tests/compiler/dart2js/link_helper.dart View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/link_test.dart View 1 2 3 4 5 6 7 2 chunks +1 line, -5 lines 0 comments Download
M tests/compiler/dart2js/lookup_member_test.dart View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/members_test.dart View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mixin_typevariable_test.dart View 1 2 3 4 5 6 7 3 chunks +13 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 2 3 4 5 6 7 4 chunks +6 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/subtype_test.dart View 1 2 3 4 5 6 7 1 chunk +17 lines, -17 lines 0 comments Download
M tests/compiler/dart2js/type_order_test.dart View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 2 3 4 5 6 7 4 chunks +6 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 2 3 4 5 6 7 2 chunks +10 lines, -15 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
karlklose
6 years, 9 months ago (2014-02-26 13:27:19 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode335 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:335: List<DartType> arguments = <DartType>[sourceType.typeArguments[0]]; Why not use 'typeArguments.first' ...
6 years, 9 months ago (2014-02-26 14:01:54 UTC) #2
karlklose
Thanks, Johnni. https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode335 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:335: List<DartType> arguments = <DartType>[sourceType.typeArguments[0]]; On 2014/02/26 14:01:54, ...
6 years, 9 months ago (2014-02-27 09:31:40 UTC) #3
Johnni Winther
https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode4187 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4187: assert(expectedType.typeArguments.isEmpty || On 2014/02/27 09:31:41, karlklose wrote: > On ...
6 years, 9 months ago (2014-02-27 09:48:23 UTC) #4
karlklose
On 2014/02/27 09:48:23, Johnni Winther wrote: > https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart > File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): > > https://codereview.chromium.org/177963002/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode4187 ...
6 years, 9 months ago (2014-03-21 10:00:08 UTC) #5
Johnni Winther
lgtm
6 years, 9 months ago (2014-03-21 10:09:22 UTC) #6
Johnni Winther
Still LGTM https://codereview.chromium.org/177963002/diff/110001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/177963002/diff/110001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1843 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1843: }); Add `, growable: false` ?
6 years, 5 months ago (2014-07-01 11:03:50 UTC) #7
karlklose
https://codereview.chromium.org/177963002/diff/110001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/177963002/diff/110001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1843 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1843: }); On 2014/07/01 11:03:50, Johnni Winther wrote: > Add ...
6 years, 5 months ago (2014-07-01 13:32:06 UTC) #8
karlklose
6 years, 5 months ago (2014-07-01 13:46:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #10 manually as r37875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698