sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart - Issue 177963002: Use List instead of Link in the type system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

Issue 177963002: Use List instead of Link in the type system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/enqueue.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

index 154f0df08e38201b45c7f875885e5e0dccac47fb..9ed094be68718094acf5ecab3261efe666ab9320 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

@@ -267,8 +267,7 @@ class JavaScriptConstantSystem extends ConstantSystem {

if (sourceType.treatAsRaw) {

keysType = compiler.listClass.rawType;

} else {

- Link<DartType> arguments =

- new Link<DartType>.fromList([sourceType.typeArguments.head]);

+ List<DartType> arguments = <DartType>[sourceType.typeArguments.first];

keysType = new InterfaceType(compiler.listClass, arguments);

}

ListConstant keysList = new ListConstant(keysType, keys);

@@ -278,7 +277,7 @@ class JavaScriptConstantSystem extends ConstantSystem {

: JavaScriptMapConstant.DART_GENERAL_CLASS;

ClassElement classElement = backend.jsHelperLibrary.find(className);

classElement.ensureResolved(compiler);

- Link<DartType> typeArgument = sourceType.typeArguments;

+ List<DartType> typeArgument = sourceType.typeArguments;

InterfaceType type;

if (sourceType.treatAsRaw) {

type = classElement.rawType;