sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart - Issue 177963002: Use List instead of Link in the type system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

Issue 177963002: Use List instead of Link in the type system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

index 7874ba2a8dbb7edce9dfab3d0e3e75c19e6cd6db..ff5b28a05e2af362616b1a05d976464ffcd8fee1 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart

@@ -93,12 +93,11 @@ void renamePlaceholders(

StringBuffer result = new StringBuffer(renameElement(type.element));

if (type is GenericType && !type.treatAsRaw) {

result.write('<');

- Link<DartType> argumentsLink = type.typeArguments;

- result.write(renameType(argumentsLink.head, renameElement));

- for (Link<DartType> link = argumentsLink.tail; !link.isEmpty;

- link = link.tail) {

+ List<DartType> arguments = type.typeArguments;

+ result.write(renameType(arguments.first, renameElement));

+ for (int index = 1; index < arguments.length; index++) {

result.write(',');

- result.write(renameType(link.head, renameElement));

+ result.write(renameType(arguments[index], renameElement));

}

result.write('>');

}