Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

Issue 177963002: Use List instead of Link in the type system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart b/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
index 2dd44a9dbe3e6537e299c0e22021bca4bd68064e..ed1dc5c8e50d9d7629c95973628f0c5a7f18350f 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
@@ -300,12 +300,13 @@ class SignatureResolver extends MappingVisitor<ParameterElementX> {
for (ParameterElement parameter in parameters) {
parameterTypes.addLast(parameter.type);
}
- Link<DartType> optionalParameterTypes = const Link<DartType>();
- Link<String> namedParameters = const Link<String>();
- Link<DartType> namedParameterTypes = const Link<DartType>();
+ List<DartType> optionalParameterTypes = const <DartType>[];
+ List<String> namedParameters = const <String>[];
+ List<DartType> namedParameterTypes = const <DartType>[];
List<Element> orderedOptionalParameters =
visitor.optionalParameters.toList();
if (visitor.optionalParametersAreNamed) {
+ // TODO(karlklose); replace when [visitor.optinalParameters] is a [List].
orderedOptionalParameters.sort((Element a, Element b) {
return a.name.compareTo(b.name);
});
@@ -316,20 +317,23 @@ class SignatureResolver extends MappingVisitor<ParameterElementX> {
namedParametersBuilder.addLast(parameter.name);
namedParameterTypesBuilder.addLast(parameter.type);
}
- namedParameters = namedParametersBuilder.toLink();
- namedParameterTypes = namedParameterTypesBuilder.toLink();
+ namedParameters = namedParametersBuilder.toLink().toList(growable: false);
+ namedParameterTypes = namedParameterTypesBuilder.toLink()
+ .toList(growable: false);
} else {
+ // TODO(karlklose); replace when [visitor.optinalParameters] is a [List].
LinkBuilder<DartType> optionalParameterTypesBuilder =
new LinkBuilder<DartType>();
for (ParameterElement parameter in visitor.optionalParameters) {
optionalParameterTypesBuilder.addLast(parameter.type);
}
- optionalParameterTypes = optionalParameterTypesBuilder.toLink();
+ optionalParameterTypes = optionalParameterTypesBuilder.toLink()
+ .toList(growable: false);
}
FunctionType type = new FunctionType(
element.declaration,
returnType,
- parameterTypes.toLink(),
+ parameterTypes.toLink().toList(growable: false),
optionalParameterTypes,
namedParameters,
namedParameterTypes);

Powered by Google App Engine
This is Rietveld 408576698