Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 177963002: Use List instead of Link in the type system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index 4ca7316ea852be70cdd2122defe1f5644d69ed84..d8b928ae467e8db711d87cbe0c10247e1fd4285f 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -1347,38 +1347,32 @@ class FunctionTypeNamer extends DartTypeVisitor {
visitFunctionType(FunctionType type, _) {
if (backend.rti.isSimpleFunctionType(type)) {
- sb.write('args${type.parameterTypes.slowLength()}');
+ sb.write('args${type.parameterTypes.length}');
return;
}
visit(type.returnType);
sb.write('_');
- for (Link<DartType> link = type.parameterTypes;
- !link.isEmpty;
- link = link.tail) {
+ for (DartType parameter in type.parameterTypes) {
sb.write('_');
- visit(link.head);
+ visit(parameter);
}
bool first = false;
- for (Link<DartType> link = type.optionalParameterTypes;
- !link.isEmpty;
- link = link.tail) {
+ for (DartType parameter in type.optionalParameterTypes) {
if (!first) {
sb.write('_');
}
sb.write('_');
- visit(link.head);
+ visit(parameter);
first = true;
}
if (!type.namedParameterTypes.isEmpty) {
first = false;
- for (Link<DartType> link = type.namedParameterTypes;
- !link.isEmpty;
- link = link.tail) {
+ for (DartType parameter in type.namedParameterTypes) {
if (!first) {
sb.write('_');
}
sb.write('_');
- visit(link.head);
+ visit(parameter);
first = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698