sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart - Issue 177963002: Use List instead of Link in the type system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 177963002: Use List instead of Link in the type system. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

index 9e6621b25a513c04a3dc3bb3d49beb2975dae954..fa6b40604489f8af4efc5d0c2aaf722d05acb733 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

@@ -313,14 +313,14 @@ class ClassEmitter extends CodeEmitterHelper {

}

if (backend.isNeededForReflection(classElement)) {

- Link typeVars = classElement.typeVariables;

+ List<DartType> typeVars = classElement.typeVariables;

Iterable typeVariableProperties = task.typeVariableHandler

.typeVariablesOf(classElement).map(js.number);

ClassElement superclass = classElement.superclass;

bool hasSuper = superclass != null;

if ((!typeVariableProperties.isEmpty && !hasSuper) ||

- (hasSuper && superclass.typeVariables != typeVars)) {

+ (hasSuper && !equalElements(superclass.typeVariables, typeVars))) {

classBuilder.addProperty('<>',

new jsAst.ArrayInitializer.from(typeVariableProperties));

}