Make new StreamController be async by default.

Make new StreamController be async by default.

Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23453

[floitsch, 2013-05-30 12:13:47]

LGTM.
Add io and html reviewers (at least as CC).

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:19: static String _truncateString(String string, int
start, int end, int length) {
make this a separate CL?

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:19: static String _truncateString(String string, int
start, int end, int length) {
comment.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:26: start = start - ((overflow + 1) >> 1);
~/ 2.
let the VM optimize this.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:38: buf.write("0123456789abcdef"[code >> 4]);
~/ 16

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:39: buf.write("0123456789abcdef"[code & 0x0f]);
% 16

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
File sdk/lib/_internal/pub/test/error_group_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
sdk/lib/_internal/pub/test/error_group_test.dart:41: expect(() =>
errorGroup.registerStream(new StreamController(sync: true).stream),
long line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
sdk/lib/_internal/pub/test/error_group_test.dart:69: expect(() =>
errorGroup.registerStream(new StreamController(sync: true).stream),
ditto.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:67: * [onResume] call might not be
executed.
Comment `sync`.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:322: runAsync(() {
Try to use addPending instead.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:573: _controller = new StreamController(sync:
true,onPause: () => _subscription.pause(),
missing new-line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:109: controller = new
StreamController<List<int>>(sync: true,
move to next line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:197: _controller = new
StreamController<_HttpIncoming>(sync: true,
move to next line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:885: _bodyController = new
StreamController<List<int>>(sync: true,
ditto.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
File sdk/lib/io/mime_multipart_parser.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:103: _controller = new
StreamController(sync: true,
next line

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:295: _multipartController = new
StreamController(sync: true,
ditto.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_server_sock...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_server_sock...
sdk/lib/io/secure_server_socket.dart:124: _controller = new
StreamController<RawSecureSocket>(sync: true,
next line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:426: _controller = new
StreamController<RawSocketEvent>(sync: true,
next line.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:569: _controller = new StreamController(sync:
true,onPause: () => _subscription.pause(),
new line missing.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/slow_consumer...
File tests/lib/async/slow_consumer_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/slow_consumer...
tests/lib/async/slow_consumer_test.dart:71: controller = new
StreamController(sync: true,
next line.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_async_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:294:
test.pause(completer.future);
indent + 2

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:323: ..expectResume()  // This
one resumes inpuot because resume is synchronous.
... input... long line.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_state_...
File tests/lib/async/stream_state_helper.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_state_...
tests/lib/async/stream_state_helper.dart:61: StreamProtocolTest.broadcast({ bool
sync: false }) : isBroadcast = true {
move initializer list to next line.

[Lasse Reichstein Nielsen, 2013-05-31 05:51:59]

Added IO/HTML as CC. 
The change should not change the current behavior, but they might want to switch
to async controllers in some places.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:19: static String _truncateString(String string, int
start, int end, int length) {
On 2013/05/30 12:13:48, floitsch wrote:
> comment.

Done.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:19: static String _truncateString(String string, int
start, int end, int length) {
Rather not. It's just a tweak that happened as part of debugging.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:26: start = start - ((overflow + 1) >> 1);
On 2013/05/30 12:13:48, floitsch wrote:
> ~/ 2.
> let the VM optimize this.

Done.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:26: start = start - ((overflow + 1) >> 1);
On 2013/05/30 12:13:48, floitsch wrote:
> ~/ 2.
> let the VM optimize this.

Done.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:38: buf.write("0123456789abcdef"[code >> 4]);
On 2013/05/30 12:13:48, floitsch wrote:
> ~/ 16

Done.

https://codereview.chromium.org/16125005/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:39: buf.write("0123456789abcdef"[code & 0x0f]);
On 2013/05/30 12:13:48, floitsch wrote:
> % 16

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
File sdk/lib/_internal/pub/test/error_group_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
sdk/lib/_internal/pub/test/error_group_test.dart:41: expect(() =>
errorGroup.registerStream(new StreamController(sync: true).stream),
On 2013/05/30 12:13:48, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/_internal/pub/test/er...
sdk/lib/_internal/pub/test/error_group_test.dart:69: expect(() =>
errorGroup.registerStream(new StreamController(sync: true).stream),
On 2013/05/30 12:13:48, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:67: * [onResume] call might not be
executed.
On 2013/05/30 12:13:48, floitsch wrote:
> Comment `sync`.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:322: runAsync(() {
On 2013/05/30 12:13:48, floitsch wrote:
> Try to use addPending instead.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:573: _controller = new StreamController(sync:
true,onPause: () => _subscription.pause(),
On 2013/05/30 12:13:48, floitsch wrote:
> missing new-line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:109: controller = new
StreamController<List<int>>(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> move to next line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:197: _controller = new
StreamController<_HttpIncoming>(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> move to next line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:885: _bodyController = new
StreamController<List<int>>(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
File sdk/lib/io/mime_multipart_parser.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:103: _controller = new
StreamController(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> next line

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:295: _multipartController = new
StreamController(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_server_sock...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_server_sock...
sdk/lib/io/secure_server_socket.dart:124: _controller = new
StreamController<RawSecureSocket>(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> next line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:426: _controller = new
StreamController<RawSocketEvent>(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> next line.

Done.

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/16125005/diff/1/sdk/lib/io/websocket_impl.dar...
sdk/lib/io/websocket_impl.dart:569: _controller = new StreamController(sync:
true,onPause: () => _subscription.pause(),
On 2013/05/30 12:13:48, floitsch wrote:
> new line missing.

Done.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/slow_consumer...
File tests/lib/async/slow_consumer_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/slow_consumer...
tests/lib/async/slow_consumer_test.dart:71: controller = new
StreamController(sync: true,
On 2013/05/30 12:13:48, floitsch wrote:
> next line.

Done.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_async_test.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:294:
test.pause(completer.future);
On 2013/05/30 12:13:48, floitsch wrote:
> indent + 2

Done.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:323: ..expectResume()  // This
one resumes inpuot because resume is synchronous.
On 2013/05/30 12:13:48, floitsch wrote:
> ... input... long line.

Done.

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_state_...
File tests/lib/async/stream_state_helper.dart (right):

https://codereview.chromium.org/16125005/diff/1/tests/lib/async/stream_state_...
tests/lib/async/stream_state_helper.dart:61: StreamProtocolTest.broadcast({ bool
sync: false }) : isBroadcast = true {
There is room?
But ok.

[Lasse Reichstein Nielsen, 2013-05-31 06:08:39]

Committed patchset #2 manually as r23453 (presubmit successful).

[blois, 2013-05-31 16:24:16]

lgtm