sdk/lib/web_audio/dartium/web_audio_dartium.dart - Issue 16125005: Make new StreamController be async by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_audio/dartium/web_audio_dartium.dart

Issue 16125005: Make new StreamController be async by default. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/web_audio/dartium/web_audio_dartium.dart

diff --git a/sdk/lib/web_audio/dartium/web_audio_dartium.dart b/sdk/lib/web_audio/dartium/web_audio_dartium.dart

index 786b08dd65fc6efdee8de584f4078f042fa68ecf..2eefb8c1551c62dabf736ba9789cecd23267013c 100644

--- a/sdk/lib/web_audio/dartium/web_audio_dartium.dart

+++ b/sdk/lib/web_audio/dartium/web_audio_dartium.dart

@@ -1258,8 +1258,8 @@ class ScriptProcessorNode extends AudioNode {

Stream<AudioProcessingEvent> get onAudioProcess {

if (_eventStream == null) {

- var controller = new StreamController();

- var callback = (audioData) {

+ var controller = new StreamController(sync: true);

+ var callback = (audioData) {

if (controller.hasListener) {

// This stream is a strange combination of broadcast and single

// subscriber streams. We only allow one listener, but if there is